Closed Bug 1543898 Opened 5 years ago Closed 5 years ago

SharedWorker must release the MessagePortIdentifier if the creation fails

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Bug 1543898 - SharedWorker must release the MessagePortIdentifier if the creation fails, r=smaug
47 bytes, text/x-phabricator-request
Details | Review

At the moment, if the SharedWorker constructor fails, we leak its messagePort because MessagePort::ForceClose() is not called anywhere here:

https://searchfox.org/mozilla-central/rev/6dab6dad9cc852011a14275a8b2c2c03ed7600a7/dom/workers/sharedworkers/SharedWorkerService.cpp#213

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/010b72a5a21c
SharedWorker must release the MessagePortIdentifier if the creation fails, r=smaug

https://hg.mozilla.org/mozilla-central/rev/010b72a5a21c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: