Closed
Bug 1543911
Opened 5 years ago
Closed 5 years ago
BasePrincipal::CloneStrippingUserContextIdAndFirstPartyDomain is misleading and it should be renamed
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
The method name BasePrincipal::CloneStrippingUserContextIdAndFirstPartyDomain suggests that the current principal is cloned and its OA is stripped. What this method actually does is to create a new principal using the current principal's origin as codebase URL (plus OA is stripped, of course).
If the current principal's codebase URL is http://example.com/foo/bar, the cloned one will have a codebase URL equal to http://example.com.
This method is extremely important for the Permission management. I suggest to rename it CloneStrippingUserContextIdAndFirstPartyDomainForPermission and add a few lines of comments to describe how it works.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9057799 -
Attachment description: Bug 1543911 - Rename BasePrincipal::CloneStrippingUserContextIdAndFirstPartyDomain to CloneStrippingUserContextIdAndFirstPartyDomainForPermission, r=johannh → Bug 1543911 - Move BasePrincipal::CloneStrippingUserContextIdAndFirst into nsPermission to avoid misuses, r=johannh
|
||
Updated•5 years ago
|
Type: defect → enhancement
Priority: -- → P3
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b22a06518604 Move BasePrincipal::CloneStrippingUserContextIdAndFirst into nsPermission to avoid misuses, r=johannh
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•5 years ago
|
Assignee: nobody → amarchesini
You need to log in
before you can comment on or make changes to this bug.
Description
•