1543973 - Perma test_nsDefaultURIFixup_info.js | xpcshell return code: 0 when Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=1759078ce933515cd0c6bcb8f40d855c4ccd92b8&selectedJob=239885635

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239909857&repo=try&lineNumber=2145

:dharvey , this seems to be caused by https://hg.mozilla.org/mozilla-central/rev/9e0b9cbb8982. Can you please take a look?

Comment 1

[Dale Harvey (:daleharvey)]

1555075140636	addons.manager	ERROR	startup failed: TypeError: Services.appinfo.version is undefined(resource://gre/modules/AddonManager.jsm:734:1) JS Stack trace: [e-mail]:734:1

Thats called from promiseStartupManager thats run in the test setup, the code thats failing looks like its:

 if (!MOZ_COMPATIBILITY_NIGHTLY) {
    PREF_EM_CHECK_COMPATIBILITY = PREF_EM_CHECK_COMPATIBILITY_BASE + "." +
                                  Services.appinfo.version.replace(BRANCH_REGEXP, "$1");
  }

Adding a check here would be a simple fix, it looks like there are a few quirks with using appinfo in the addon manager, and this is one of only 2 uses of MOZ_COMPATIBILITY_NIGHTLY so would be great if someone on from addons could suggest what would be the correct fix here, Kris you have any pointers? Thanks

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1543973 - Switch to AppConstants to avoid appinfo conflict. r?mixedpuppy

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac38a6790d00
Switch to AppConstants to avoid appinfo conflict. r=mixedpuppy

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ac38a6790d00

Comment 5

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9064a77fe72c606c2e0e1d7562ceb8d27da12e39&selectedJob=241173212