1543983 - Pop-up security level indicator is missing on the "about:compat" page

Status: VERIFIED FIXED

(Web Compatibility :: Tooling & Investigations, defect, P1)

Description

[Eliza Balazs]

Environment:
Device: OnePlus 5T(Android 9);
Build: Nightly 68.0a1 (2019-04-11);

Steps to reproduce:

1. Go to "about:compat" page;
2. Tap on the grey globe icon;
3. Observe the behavior.

Expected result:
A pop-up security level indicator is displayed with the message: "This is a secure Nightly page".

Actual result:
The pop-up security level indicator is missing.

Notes:

• On Desktop, the message: "This page is stored on your computer." is displayed.

Comment 1

[Thomas Wisniewski [:twisniewski]]

On desktop the issue also happens for about:about, about:networking, about:debugging, and those are just the ones I've tested. They end up being shown the connectionFile text instead of the connectionInternal case in browser/components/controlcenter/content/panel.inc.xul:

          <description when-connection="chrome">&identity.connectionInternal;</description>
          <description when-connection="file">&identity.connectionFile;</description>

So I'm guessing that's fine?

However on mobile the problem is that there is a whitelist that about:compat isn't in yet in mobile/android/chrome/content/browser.js:

    let whitelist = /^about:(about|accounts|addons|buildconfig|cache|config|crashes|devices|downloads|experiments|fennec|firefox|feedback|home|license|logins|logo|memory|mozilla|networking|privatebrowsing|rights|serviceworkers|support|telemetry|webrtc)($|\?)/i;
    if (uri.schemeIs("about") && whitelist.test(uri.spec)) {
        return this.IDENTITY_MODE_CHROMEUI;
    }

I'm making a test build right now to confirm if that's all it is.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Yes, that seems to do the trick on Fennec. I'll just do a try-run to sniff out any potential test breakage changing that whitelist causes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4093b630ffc7ad7714c2ae838b4dfd8d7b09446

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1543983 - Whitelist about:compat as a secure page on Fennec; r?snorp

Whitelist about:compat as a secure page on Fennec

Comment 4

[Thomas Wisniewski [:twisniewski]]

I don't see anything out of the ordinary on the try-run, so I'm requesting review.

Comment 5

[Mike Taylor [:miketaylr]]

Let's fix this for mobile, and the issue is ambiguous on desktop, so we won't block this feature on that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/724fc2049046
Whitelist about:compat as a secure page on Fennec; r=snorp

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/724fc2049046

Comment 8

[Eliza Balazs]

Hi!

I tested this issue on the latest version of Nightly 68.0a1 (2019-04-17) with OnePlus 5T (Android 9) and I wasn't able to reproduce the issue.

Due to my findings, I'll mark this issue as verified on Firefox 68.

Thanks.