Open Bug 1543998 Opened 4 months ago Updated 2 months ago

Add UserTiming markers for Discovery Stream events

Categories

(Firefox :: New Tab Page, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: andreio, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

UserTiming markers are useful in profile captures to signal when specific events happened.
detect-user-session-start.js notifies when the new tab page became visible to the user.
We should add something similar for when sections have rendered, data finished downloading or other events that might be interesting.

Type: defect → enhancement
Iteration: --- → 68.3 - Apr 15 - 28
Priority: -- → P1
No longer blocks: pocket-newtab-68
Assignee: nobody → andrei.br92
Iteration: 68.3 - Apr 15 - 28 → 68.4 - Apr 29 - May 12

It looks like we get this for free if we turn on react-dev. Maybe the scope of this bug should change to see if we can use the profile data to plot timing information.

Iteration: 68.4 - Apr 29 - May 12 → ---
Priority: P1 → P2

Do you think it makes sense to include/use profiler markers in the performance numbers?
What I like about this is that it's easy to get this information, you only have to start the browser and it's already computed for you. This could easily be included as part of the review process when changing a component: we could compare before and after applying a patch and look at duration field of several browser startups for that component (like Topsites in my screenshot).
The cool thing is that using the profiler you can make network requests so it's working with real world data.

Flags: needinfo?(sdowne)
No longer blocks: pocket-newtab-69
No longer blocks: pocket-newtab-68
Assignee: andrei.br92 → nobody

Let us know what you think for 69

Flags: needinfo?(gsuntop)
Assignee: nobody → gsuntop
Priority: P2 → P1

I think adding these markers probably makes sense!

Flags: needinfo?(gsuntop)
Assignee: gsuntop → nobody
Flags: needinfo?(sdowne)
Priority: P1 → P3
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.