1544111 - Fix HTML about:addons to work with dark in-content pages

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Tim Nguyen :ntim]

Attachment: image.png

STR:

• Enable extensions.htmlaboutaddons.enabled
• Enable browser.in-content.dark-mode
• Enable your MacOS/Windows dark mode, or use a dark GTK theme
• Visit about:addons

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1544111 - Fix contrast of various elements in HTML about:addons in dark mode. r=dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d5e9d6d4dff
Fix contrast of various elements in HTML about:addons in dark mode. r=dao

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 1d5e9d6d4dff (bug 1544111) for Browser-Chrome failures in browser/base/content/test/static/browser_parsable_css.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242685796&repo=autoland&lineNumber=2900

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1d5e9d6d4dffe8de0d1f110f78f12b5002af4b7b

Backout:
https://hg.mozilla.org/integration/autoland/rev/7e40e33da3da2640e965a153254594a234231f76

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c643e1215c7
Fix contrast of various elements in HTML about:addons in dark mode. r=dao

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing /browser_parsable_css.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=242834558&searchStr=os%2Cx%2C10.10%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx64-shippable%2Fopt-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&revision=0c643e1215c76d16f9efb5b7255f7051ffc75597

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242844451&repo=autoland&lineNumber=2763

Backout: https://hg.mozilla.org/integration/autoland/rev/58aa4aaf609110efbd62c535050f8d6ddef697fa

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba5045bb0072
Fix contrast of various elements in HTML about:addons in dark mode. r=dao

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ba5045bb0072

Comment 8

[CosminB]

Attachment: Bug1544111.zip

This issue is verified as fixed on Firefox 68.0a1 (20190503041749) under Win 10 32-bit and Mac OS X 10.14.1.

Browser from the bottom side is the affected version and the one from the top is the fixed version.

Please see the attached screenshots.