1544195 - Asterisk doesn't work as wildcard character in about:config anymore

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[avada]

This is a usability regression. It came in pretty handy when one didn't know the exact wording of a preference.
Don't know when this stopped working, my guess is with the new about:config UI.

Example: apz.*allow doesn't give any results in latest trunk. But shows the appropriate three settings in 56.

Comment 1

[Julien Cristau [:jcristau]]

The new about:config is nightly only for now.

Comment 2

[YUKI "Piro" Hiroshi]

Attachment: Bug 1544195 - Support wildcard on about:config

Comment 3

[YUKI "Piro" Hiroshi]

I'm trying to implement that. Testing on the tryserver: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b9f81cc809c6657bd30a2abb9b03342e529c863 https://treeherder.mozilla.org/#/jobs?repo=try&revision=83eb2af9880e0b7e77303a78a8b63334047da6f3

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hi Yuki,

Thanks for the patch! This looks great - I'm super glad to see you added a test, too.

Your second try push is reporting failures in your newly added test:

05:16:06     INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/about-config-pref-accessible-value-custom: RangeError: Too many characters in placeable (7122, max allowed is 2500)."]
05:16:06     INFO - Buffered messages finished
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 4 == 3 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 88
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:88
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Not taking screenshot here: see the one that was previously logged
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 3 == 2 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 92
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:92
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Not taking screenshot here: see the one that was previously logged
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 2 == 1 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 94
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:94
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Not taking screenshot here: see the one that was previously logged
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 4 == 3 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 96
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:96
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Not taking screenshot here: see the one that was previously logged
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 2 == 1 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 100
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:100
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Not taking screenshot here: see the one that was previously logged
05:16:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutconfig/test/browser/browser_search.js | 2 == 1 - JS frame :: chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js :: test_search_wildcard/< :: line 102
05:16:06     INFO - Stack trace:
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard/<:102
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab/<:87
05:16:06     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/head.js:withNewTab:81
05:16:06     INFO - chrome://mochitests/content/browser/browser/components/aboutconfig/test/browser/browser_search.js:test_search_wildcard:85
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
05:16:06     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
05:16:06     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
05:16:06     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
05:16:06     INFO - Leaving test bound test_search_wildcard
05:16:06     INFO - Entering test bound test_search_delayed
05:16:06     INFO - GECKO(3254) | JavaScript error: , line 0: uncaught exception: [fluent][resolver] errors in en-US/about-config-pref-accessible-value-custom: RangeError: Too many characters in placeable (7122, max allowed is 2500).
05:16:06     INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/about-config-pref-accessible-value-custom: RangeError: Too many characters in placeable (7122, max allowed is 2500)."]
05:16:07     INFO - GECKO(3254) | JavaScript error: , line 0: uncaught exception: [fluent][resolver] errors in en-US/about-config-pref-accessible-value-custom: RangeError: Too many characters in placeable (7122, max allowed is 2500).
05:16:07     INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/about-config-pref-accessible-value-custom: RangeError: Too many characters in placeable (7122, max allowed is 2500)."]
05:16:07     INFO - TEST-PASS | browser/components/aboutconfig/test/browser/browser_search.js | 0 == 0 - 
05:16:07     INFO - TEST-PASS | browser/components/aboutconfig/test/browser/browser_search.js | 993 > 0 - 
05:16:07     INFO - TEST-PASS | browser/components/aboutconfig/test/browser/browser_search.js | 2 == 2 - 
05:16:08     INFO - TEST-PASS | browser/components/aboutconfig/test/browser/browser_search.js | 2 == 2 - 
05:16:08     INFO - TEST-PASS | browser/components/aboutconfig/test/browser/browser_search.js | 1 == 1 - 
05:16:08     INFO - Leaving test bound test_search_delayed
05:16:08     INFO - GECKO(3254) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 110: uncaught exception: Object
05:16:08     INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 110}]
05:16:08     INFO - GECKO(3254) | MEMORY STAT | vsize 5768MB | residentFast 647MB | heapAllocated 382MB

any idea what's going wrong? I'm going to request changes on the patch until we can get this figured out.

Comment 5

[YUKI "Piro" Hiroshi]

Sorry I forgot that "rows" includes the row to add new preference. I've updated the patch, and now it passes on my local environment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a071ce73f010
Support wildcard on about:config r=mconley

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a071ce73f010