1544216 - Fix issues found by mach static-analysis check

Status: RESOLVED FIXED

(Core :: SVG, task, P3)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 1 - use default keyword instead of empty constructors and destructors

Comment 3

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 2 - No else after return

Comment 4

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 3 - Simplify boolean logic

Comment 5

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 4 - Use modern looping

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18169336baef
Part 1 - use default keyword instead of empty constructors and destructors r=birtles

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d886995a0251
Part 2 - no else after return r=birtles
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c81fd084c4f
Part 3 - simplify boolean logic r=birtles
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb417cb36790
Part 4 - use modern looping r=birtles

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/18169336baef
https://hg.mozilla.org/mozilla-central/rev/d886995a0251
https://hg.mozilla.org/mozilla-central/rev/6c81fd084c4f
https://hg.mozilla.org/mozilla-central/rev/fb417cb36790

Comment 9

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 5 - add noexcept to move constructors and reassignment operators

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d57a72036d3
Part 5 - add noexcept to move constructors and reassignment operators r=birtles

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b617fdd89077
Backed out 2 changesets (bug 1544216, bug 1542646) for wpt failures at style-src-multiple-policies-multiple-hashing-algorithms.html and report-cross-origin-no-cookies.sub.html.

Comment 12

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1544216, Bug 1542646) for wpt failures at style-src-multiple-policies-multiple-hashing-algorithms.html and report-cross-origin-no-cookies.sub.html.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/b617fdd890779198b7e7ea269e1744c6de561904

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=242445138&revision=9d57a72036d3ce614762bdb48bdcd1311bc72f12

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242445138&repo=mozilla-inbound&lineNumber=2074
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242455008&repo=mozilla-inbound&lineNumber=1649

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2c69004a29
Part 5 - add noexcept to move constructors and reassignment operators r=birtles

Comment 14

[Cristian Brindusan [:cbrindusan]]

Please ignore the backout comment, I've re-landed these changes again because the issue seems to be from Bug 1546858.
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=6af618355c3695f2eb55b9087f018a581a06f601&tochange=abd3b11a17de82df681fabe339ca33ae7ab65ff4&fromchange=a9e8bb1d8a1617763205dc0ef46ec4fd663113cf&selectedJob=242489382

Comment 15

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2d2c69004a29

Comment 16

[Robert Longson [:longsonr]]

Attachment: Bug 1544216 Part 6 - Make function declaration and definition parameter names match

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a2a6da7e899
Part 6 - Make function declaration and definition parameter names match r=birtles

Comment 18

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2a2a6da7e899

Comment 19

[Robert Longson [:longsonr]]

I've not fixed everything but this is probably enough for one bug.