1544225 - An extension requires container tabs message not displayed correctly in dark mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Asif Youssuff]

STR:

1. enable browser.in-content.dark-mode
2. Enable dark mode in OS
3. Install any container add-on. The one that appears in my screenshot is https://addons.mozilla.org/en-US/firefox/addon/twitter-container/
4. Navigate to about:preferences

What happens:

The message that appears "An Extension Twitter Container Requires Container Tabs" is not displayed correctly in dark mode.

Expected result:

This message should be themed nicely.

Comment 1

[Asif Youssuff]

Attachment: Screenshot from 2019-04-13 14-25-33.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:yoasif, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 3

[Asif Youssuff]

:calixte I think it is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1519548

Comment 4

[Kestrel]

Attachment: Bug 1544225 - Fix more background colors and icon fill colors for about:preferences dark mode

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca84ee52da5
Fix more background colors and icon fill colors for about:preferences dark mode r=dao

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5ca84ee52da5

Comment 9

[Cristian Fogel [:cfogel]]

Confirmed issue with 68.0a1 (2019-04-21) (64-bit).
Verified fix with 68.0.1 69.0b7 on Windows 10, macOS 10.14 in junction with bug 1553385.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.