Closed Bug 1544240 Opened 2 years ago Closed 2 years ago

Polish the Debugger's Watch Expression Pane

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jarilvalenciano, Assigned: jarilvalenciano)

Details

(Whiteboard: [qa-68b-p2])

Attachments

(2 files)

Screen Shot 2019-04-13 at 3.18.54 PM.png
22.86 KB, image/png
Details
Bug 1544240 - Fixed Watch Expression vertical alignment r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36

Steps to reproduce:

  1. Open the debugger
  2. Add a watch expression
  3. Inspect the .expression-container element

The element should be 20px high, not 18px, as per https://github.com/firefox-devtools/debugger/pull/8066.

Actual results:

There was UX regression in the PR while resolving a merge conflict.

Expected results:

The .expression-container style should have 3px instead of 2px for padding-top and padding-bottom.

Set the expression container to 20px

Component: Untriaged → Debugger
Product: Firefox → DevTools
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f93f4060ac7d
Fixed Watch Expression vertical alignment r=davidwalsh

https://hg.mozilla.org/mozilla-central/rev/f93f4060ac7d

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → jarilvalenciano
Whiteboard: [qa-68b-p2]
You need to log in before you can comment on or make changes to this bug.