High frequency security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | xpcshell return code: -11 when Gecko 68 merges to Beta on 2019-05-06
Categories
(Core :: Security: PSM, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | fixed |
firefox66 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | wontfix |
firefox70 | --- | wontfix |
firefox71 | --- | fixed |
firefox72 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: keeler)
References
Details
(Keywords: intermittent-failure, regression, Whiteboard: [psm-assigned])
Attachments
(3 files)
#[markdown(off)]
Filed by: apavel [at] mozilla.com
https://treeherder.mozilla.org/logviewer.html#?job_id=240158462&repo=try
Central as Beta sim
[task 2019-04-13T13:59:36.780Z] 13:59:36 INFO - TEST-START | services/sync/tests/unit/test_clients_engine.js
[task 2019-04-13T13:59:42.802Z] 13:59:42 INFO - TEST-PASS | services/sync/tests/unit/test_clients_engine.js | took 6025ms
[task 2019-04-13T13:59:42.810Z] 13:59:42 INFO - Retrying tests that failed when run in parallel.
[task 2019-04-13T13:59:42.819Z] 13:59:42 INFO - TEST-START | security/manager/ssl/tests/unit/test_toolkit_securityreporter.js
[task 2019-04-13T13:59:43.122Z] 13:59:43 WARNING - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | xpcshell return code: -11
[task 2019-04-13T13:59:43.124Z] 13:59:43 INFO - TEST-INFO took 303ms
[task 2019-04-13T13:59:43.124Z] 13:59:43 INFO - >>>>>>>
[task 2019-04-13T13:59:43.124Z] 13:59:43 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-04-13T13:59:43.124Z] 13:59:43 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - running event loop
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | Starting
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-04-13T13:59:43.125Z] 13:59:43 INFO - TEST-PASS | security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | - Binary util BadCertServer should exist - true == true
[task 2019-04-13T13:59:43.127Z] 13:59:43 INFO - TEST-PASS | security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | - certificate folder (bad_certs) should exist - true == true
[task 2019-04-13T13:59:43.127Z] 13:59:43 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2019-04-13T13:59:43.127Z] 13:59:43 INFO - PID 13031 | sending 'GET / HTTP/1.0
[task 2019-04-13T13:59:43.128Z] 13:59:43 INFO - PID 13031 | '
[task 2019-04-13T13:59:43.130Z] 13:59:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-04-13T13:59:43.130Z] 13:59:43 INFO - (xpcshell/head.js) | test finished (2)
[task 2019-04-13T13:59:43.130Z] 13:59:43 INFO - PID 13031 | HTTP/1.0 200 OK
[task 2019-04-13T13:59:43.131Z] 13:59:43 INFO - PID 13031 | content-type: text/plain
[task 2019-04-13T13:59:43.132Z] 13:59:43 INFO - PID 13031 | connection: close
[task 2019-04-13T13:59:43.133Z] 13:59:43 INFO - PID 13031 | server: httpd.js
[task 2019-04-13T13:59:43.134Z] 13:59:43 INFO - PID 13031 | date: Sat, 13 Apr 2019 13:59:42 GMT
[task 2019-04-13T13:59:43.135Z] 13:59:43 INFO - PID 13031 | content-length: 3
[task 2019-04-13T13:59:43.136Z] 13:59:43 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2019-04-13T13:59:43.137Z] 13:59:43 INFO - (xpcshell/head.js) | test finished (2)
[task 2019-04-13T13:59:43.138Z] 13:59:43 INFO - security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | Starting
[task 2019-04-13T13:59:43.139Z] 13:59:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-04-13T13:59:43.139Z] 13:59:43 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2019-04-13T13:59:43.140Z] 13:59:43 INFO - PID 13031 | found pre-defined host 'expired.example.com'
[task 2019-04-13T13:59:43.141Z] 13:59:43 INFO - PID 13031 | found pre-defined host 'expired.example.com'
[task 2019-04-13T13:59:43.141Z] 13:59:43 INFO - PID 13031 | PR_Recv failed: SSL_ERROR_EXPIRED_CERT_ALERT
[task 2019-04-13T13:59:43.142Z] 13:59:43 INFO - "handling expired.example.com"
[task 2019-04-13T13:59:43.143Z] 13:59:43 INFO - TEST-PASS | security/manager/ssl/tests/unit/test_toolkit_securityreporter.js | - Actual and expected connection result should match - 2153390069 == 2153390069
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See How Do You Triage for more information
Assignee | ||
Comment 3•5 years ago
|
||
Before this patch, test_toolkit_securityreporter.js would unconditionally try to
get the value of the "Cookie" header. If a header isn't available, httpd.js
apparently throws an exception. Interestingly, exceptions thrown in httpd.js
path handlers aren't reported to the test framework, so we weren't aware of
this. Additionally, the test didn't have any way of waiting until the security
report it was expecting had arrived, so it just continued on and "succeeded".
This patch addresses these issues by using "throws" to make sure no cookies are
available and by inserting extra add_test/run_next_test pairs when the test is
waiting for a report.
Assignee | ||
Comment 4•5 years ago
|
||
This is a bit speculative, so I'll mark this leave-open for now.
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2091fc58b131 fix cookie-checking in test_toolkit_securityreporter.js r=mgoodwin
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
This still occurs in recent beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5934df7d1b1ee6c3f80480a58d3224c8b37aa0e4&selectedJob=241702461
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 9•5 years ago
|
||
Thanks for checking - I'm still looking into this.
Assignee | ||
Comment 10•5 years ago
|
||
test_toolkit_securityreporter.js uses BadCertServer, which uses hard-coded
ports, so it needs to run sequentially.
Comment 11•5 years ago
|
||
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/216356ce131f run test_toolkit_securityreporter.js sequentially (it uses hard-coded ports) r=mgoodwin
Comment 12•5 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment 14•5 years ago
|
||
No occurences in the most recent beta sims:
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
Hi Dana, are there any updates for this one? (tracking for 68) Thanks!
Assignee | ||
Comment 17•5 years ago
|
||
No updates, really - I haven't had time to look into this further (but it looks like it may be slightly less frequent based on comment 14 and comment 15?)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 20•5 years ago
|
||
Updated•5 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 26•5 years ago
|
||
This is looking pretty frequent on 68 along with bug 1563652. Can you please take another look, Dana?
Assignee | ||
Comment 27•5 years ago
|
||
Let's see how this does: https://treeherder.mozilla.org/#/jobs?repo=try&revision=adea49567a76dfb02a721fc45e7020a4c789411d
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 44•5 years ago
|
||
Any chance you can look at this once more, Dana? Thank you in advance.
Assignee | ||
Comment 45•5 years ago
|
||
Assignee | ||
Comment 46•5 years ago
|
||
We can disable this - the feature it tests is disabled by default, and will probably be removed anyway.
Assignee | ||
Updated•5 years ago
|
Comment 47•5 years ago
|
||
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36c6363aa297 disable test_toolkit_securityreporter.js because TLS error reports are disabled by default and it intermittently fails r=kjacobs
Comment 48•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 49•5 years ago
|
||
bugherder uplift |
Comment hidden (Intermittent Failures Robot) |
Comment 51•5 years ago
|
||
bugherder uplift |
Description
•