Open Bug 1544317 Opened 6 months ago Updated 2 months ago

some new tabs >1.5mb while the others are ~262kb

Categories

(Firefox :: New Tab Page, defect, P2)

defect

Tracking

()

People

(Reporter: dietrich, Assigned: thecount)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(2 files)

68.0a1 (2019-04-11) (64-bit) Mac OS X

Screenshot attached of about:performance

Seems weird that some empty tabs are 4x more memory than the rest.

Flags: needinfo?(erahm)

Could you include an about:memory report?

Flags: needinfo?(autonome)
Attached file memory-report.json.gz

In this one, similar pattern but different numbers. Most are around ~260kb and two are ~871kb.

Flags: needinfo?(autonome)

There's something like 13 about:blank windows reported under the parent process, all with 0.07MB. Most of that is under js-realm/classes. TBH I'm not sure where about:performance is getting it's numbers, this might just be a reporting problem.

My standard recommendation here is to start in safe mode and see if you get the same behavior, I'm reasonably sure this is extension related.

Flags: needinfo?(erahm)

Confirmed that in safe mode, the heavier about:blank windows are gone, so it must be that extensions are able to make this happen.

Seems like that shouldn't be possible with WebExtension APIs?

Going to kick this to WebExtensions now not knowing the answer to comment 4.

Product: Firefox → WebExtensions

I don't see any evidence that this has anything to do with the extension framework, and I don't really have much to go on.

What is in the new tabs? Activity stream? about:blank? Something provided by an extension?

In the latter two cases, it's possible that an extension could be responsible, but that would not, strictly speaking, be a bug. Certainly not a framework bug. In the Activity Stream case, that would be an AS bug.

What about:memory entries do these about:performance entries correspond to? What are their real URLs? Without knowing that, there isn't really anything I can say about them.

Product: WebExtensions → Firefox

(In reply to Kris Maglione [:kmag] from comment #6)

I don't see any evidence that this has anything to do with the extension framework, and I don't really have much to go on.

What is in the new tabs? Activity stream? about:blank? Something provided by an extension?

In the latter two cases, it's possible that an extension could be responsible, but that would not, strictly speaking, be a bug. Certainly not a framework bug. In the Activity Stream case, that would be an AS bug.

What about:memory entries do these about:performance entries correspond to? What are their real URLs? Without knowing that, there isn't really anything I can say about them.

Fair enough. Dietrich, assuming you can still reproduce this, can you get the exact URLs for the entries in about:performance?

Also, if you could try narrowing this down to a particular extension, that could be very helpful.

Flags: needinfo?(autonome)

In about:performance, double-clicking on those tabs should switch you to them. Are you able to find a difference between the tabs that have lower memory consumption over the ones with higher memory consumption? If they're all Activity Stream, for example, are the images displayed different?

Great help, thanks mconley! I had no idea you could do that.

They are new-tab pages.

I thought I was able to reproduce without any extensions enabled, but now I cannot reproduce even with all my extensions enabled. It must be because I'm looking.

I'll keep trying to narrow down to a specific extension.

Some other maybe relevant info:

  • I usually have 7-10 windows open which have a new empty tab as the active tab

  • The heavy tabs are always two of those new tabs

  • My home page setting is "Blank Page"

  • Always only 2 new-tabs using way more memory, and the rest about the same (~260kb)

  • Those 2 new-tabs are always ~same memory usage as each other

  • Their size fluctuates - I've seen from ~800kb to 23mb (!) per tab for these two

  • No pattern in how much memory used by them - but always went up or down, didn't stay the same between restarts

Flags: needinfo?(autonome)
Component: General → Activity Streams: Newtab
Whiteboard: [MemShrink] → [MemShrink:P2]

Right now I have a bunch of empty new-tabs but two that are 2.2mb each according to about:performance. They're both in windows that I haven't been interacting with.

Screenshot: https://i.imgur.com/pZJAYm6.png

Assignee: nobody → sdowne
Iteration: --- → 69.1 - May 13 - 26
Priority: -- → P1

I tried to take a look at this from an activity stream/pocket point of view.

I tried to reproduce the original issue but couldn't.

I did noticed a few things that seem like maybe concerning.

My numbers in about:performance are much more consistent, and I tried turning on and off various new tab features to see if any of them causes more issues than others, still relatively similar.

The one thing I did notice, my numbers were much higher. With everything turned off in new tab, I still had about 3.6mb in memory. As I turned on features, it settles at around 6mb. Seems high compared to the original issue's report of 260 kb.

No longer blocks: pocket-newtab-68
Iteration: 69.1 - May 13 - 26 → 69.3 - Jun 10 - 23
No longer blocks: pocket-newtab-69
Iteration: 69.3 - Jun 10 - 23 → ---
Priority: P1 → P2
Component: Activity Streams: Newtab → New Tab Page
Priority: P2 → P1
Priority: P1 → P2
You need to log in before you can comment on or make changes to this bug.