Closed Bug 1544400 Opened 8 months ago Closed 8 months ago

Upgrade Linux fuzzing builds to Clang 8 + gold

Categories

(Firefox Build System :: Task Configuration, task)

x86_64
Linux
task
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

Details

Attachments

(1 file)

In bug 1541943 we downgraded Clang for fuzzing builds due to a problem with libFuzzer instrumentation. In general, the libFuzzer developers recommend the use of gold as a linker to avoid the type of problem we are hitting.

I've made a try push with --enable-gold here

https://treeherder.mozilla.org/#/jobs?repo=try&revision=296aa7ec7a26b8feaad0d69d334c2d91dca61bf2

and confirmed that the resulting build is usable for fuzzing.

:glandium, are there reasons that would speak against the use of gold for these builds? If not, then I would go ahead and make the necessary changes so we can have all builds use Clang 8.

Flags: needinfo?(mh+mozilla)

Go for it.

Flags: needinfo?(mh+mozilla)

The submitted patch makes the necessary build config changes, but it also includes a libFuzzer update to match the Clang 8 revision we use now. In general, it is advisable to keep libFuzzer in sync with the Clang version used.

Also, this is green on try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15215d3c82d325c391623806d979f8f9433bde58

and I did some smoke tests with the builds to confirm that they work.

Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4de96f2d275
Update fuzzing builds to Clang 8 and use gold. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.