Some items in panels can't be opened with the numpad's Enter key
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
STR:
- Lastet Nightly, Windows 10
- Open bugzilla.mozilla.org
- Click the Site Identity panel
- Navigate to Trackers, Cookies or Report a problem
- Hit the Enter key in the numpad
AR:
Nothing happens
ER:
Pressing the numpad's Enter key should open the respective panels.
I'm not sure atm if this is a regression from bug 1477673 or if this was an issue even before.
|
||
Comment 1•5 years ago
|
||
:itiel_yn8, if you think that's a regression, then could you try to find a regression range in using for example mozregression?
|
||
Comment 2•5 years ago
|
||
I very much doubt this is a regression, though I haven't tested it. The PanelMultiView code explicitly handles Enter, but not NumpadEnter (and this isn't something I changed):
https://searchfox.org/mozilla-central/source/browser/components/customizableui/PanelMultiView.jsm#1647
This should be a trivial fix, but needs tests.
This didn't work before anyway because of all of the 3 buttons didn't open using the normal Enter or the space key (bug 1539976, among the rest).
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/515cfc853f2a add support for numpad enter key and add tests to check activation works, r=Jamie
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•