determine if osx screenresolution is needed on osx

RESOLVED FIXED in Firefox 68

Status

defect
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

(Blocks 1 bug)

Version 3
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 months ago

in raptor and talos we call screenresolution:
https://searchfox.org/mozilla-central/source/testing/mozharness/configs/raptor/mac_config.py#5
https://searchfox.org/mozilla-central/source/testing/mozharness/configs/talos/mac_config.py#5

this tool isn't possible to compile on OSX 10.14 due to old APIs, do we need this?

Assignee

Comment 1

2 months ago

:rwood, is this required, do you need more information to make a decision? If it is required, we need to determine what we need from it and how to meet those needs in a modern OSX version.

Flags: needinfo?(rwood)

TBH I have no idea if that is required or not. I personally don't remember specifically adding that, and am guessing maybe it's just carry-over from copying the machine configs from talos (?). Offhand I don't see why a screen resolution check would be required for Raptor.

Flags: needinfo?(rwood)
Assignee

Comment 3

2 months ago

remove screen resolution check from os perf configs

Comment 5

2 months ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b3d5e8d716d
remove screen resolution check from osx perf configs. r=rwood

Comment 6

2 months ago
bugherder
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.