1544473 - determine if osx screenresolution is needed on osx

Status: RESOLVED FIXED

(Testing :: Performance, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in raptor and talos we call screenresolution:
https://searchfox.org/mozilla-central/source/testing/mozharness/configs/raptor/mac_config.py#5
https://searchfox.org/mozilla-central/source/testing/mozharness/configs/talos/mac_config.py#5

this tool isn't possible to compile on OSX 10.14 due to old APIs, do we need this?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:rwood, is this required, do you need more information to make a decision? If it is required, we need to determine what we need from it and how to meet those needs in a modern OSX version.

Comment 2

[Robert Wood [:rwood]]

TBH I have no idea if that is required or not. I personally don't remember specifically adding that, and am guessing maybe it's just carry-over from copying the machine configs from talos (?). Offhand I don't see why a screen resolution check would be required for Raptor.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1544473 - remove screen resolution check from osx perf configs. r=rwood

remove screen resolution check from os perf configs

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

here is a try push showing the results, appears like a normal try push:
https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=test-mac&revision=92b4df7c5f3b32054305ac786c428cc7432c7e45

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b3d5e8d716d
remove screen resolution check from osx perf configs. r=rwood

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2b3d5e8d716d