1544478 - WebM rendered skewed on macOS

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Dennis Schubert [:denschub]]

This WebM is rendered with a 45 degrees skew on macOS in Nightly, see the attached screenshot. This works fine in Release and on Windows in Nightly. Running mozregression returned this push, and bug 1479145 jumps out as something that could be related.

Requesting tracking for 67 and 68, because the issue is reproducible in 67, and the patch in question got uplifted.

Comment 1

[Dennis Schubert [:denschub]]

Markus, do you have an idea on what might cause this?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This is very likely caused by bug 1479145.

Comment 3

[Pascal Chevrel:pascalc]

Tracking for 67, if we can't get a fix before Beta 13 for this regression, we will back out bug 1479145 from beta.

Comment 4

[Markus Stange [:mstange]]

This is a WebM with alpha information, so YUV->RGBA conversion is done on the CPU. We're not respecting the correct stride in that code path.

Comment 5

[Markus Stange [:mstange]]

Sorry Pascal, I mid-aired the tracking flag away.

Comment 6

[Markus Stange [:mstange]]

Attachment: test.html

Comment 7

[Markus Stange [:mstange]]

Attachment: reference.html

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1544478 - Respect SharedRGBImage's stride during YUV->RGBA conversion. r?mattwoodrow

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1544478 - Add a reftest. r?mattwoodrow

Depends on D27600

Comment 10

[Markus Stange [:mstange]]

Attachment: Bug 1544478 - Stub out SharedPlanarYCbCrImage::AdoptData because it can't be called without crashing, which means it's unused. r?mattwoodrow

GetBuffer() would always return null here.

Depends on D27601

Comment 11

[Markus Stange [:mstange]]

Attachment: Bug 1544478 - Remove unused method Image::GetBuffer(). r?mattwoodrow

Depends on D27603

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3fbdaa46b9
Respect SharedRGBImage's stride during YUV->RGBA conversion. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/d5ac9681d3ce
Add a reftest. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4ab1a110e5d5
Stub out SharedPlanarYCbCrImage::AdoptData because it can't be called without crashing, which means it's unused. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/185e608c3852
Remove unused method Image::GetBuffer(). r=mattwoodrow

Comment 13

[Markus Stange [:mstange]]

Try push before fuzz adjustment: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96ac78ab8543f5e827d58559f84882657987f88b

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cf3fbdaa46b9
https://hg.mozilla.org/mozilla-central/rev/d5ac9681d3ce
https://hg.mozilla.org/mozilla-central/rev/4ab1a110e5d5
https://hg.mozilla.org/mozilla-central/rev/185e608c3852

Comment 16

[Markus Stange [:mstange]]

Comment on attachment 9058424 [details]
Bug 1544478 - Respect SharedRGBImage's stride during YUV->RGBA conversion. r?mattwoodrow

Beta/Release Uplift Approval Request

• User impact if declined: Some videos (WebM with alpha) will be displayed with a skew on macOS
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is small and tightly-scoped, and applies to code which is only run for a certain type of video.
• String changes made/needed:

Comment 17

[Pascal Chevrel:pascalc]

Comment on attachment 9058424 [details]
Bug 1544478 - Respect SharedRGBImage's stride during YUV->RGBA conversion. r?mattwoodrow

The regression is very visible for a subset of our users and the patch looks safe and has tests. There is no request for manual QA while we have STR in comment #0, so let's ask for QA after landing on beta. Uplift accepted for 67 beta 13, thanks.

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1cf183a8be97
https://hg.mozilla.org/releases/mozilla-beta/rev/9b2635dc41a4
https://hg.mozilla.org/releases/mozilla-beta/rev/fe4d81fb62b8
https://hg.mozilla.org/releases/mozilla-beta/rev/86f6ec90b34b

Comment 19

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue on 67.0b12 on Mac 10.13.6

Verified as fixed on Mac 10.13.6 on 67.0b13 and 68.0a1 20190424095359.