Closed Bug 1544501 Opened 8 months ago Closed 8 months ago

Convert the ToolbarContextMenu to use strings from Fluent

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: jaws, Assigned: nautilus, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Similar to bug 1523763, we should move the ToolbarContextMenu strings to Fluent.

The strings are defined at https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/browser/locales/en-US/chrome/browser/browser.dtd#83-106 and should be moved to a new file at browser/locales/en-US/browser/toolbarContextMenu.ftl

The migration script should be created at:
/python/l10n/fluent_migrations

/browser/base/content/browser.xul will need to be updated to replace the label and accesskey attributes with a data-lazy-1l0n-id attribute.

https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/browser/base/content/browser.js#5848 will need to be updated to insert the FTL on demand. Let's see first if we can just insert the FTL during onpopupshowing (the onViewToolbarsPopupShowing event), otherwise we may need to insert based on mousemove over the toolbar and keydown in the location bar.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d566c68b2876
Convert the ToolbarContextMenu to use strings from Fluent r=jaws,flod
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.