Open Bug 1544527 Opened 8 months ago Updated Last month

[Accessibility] Search field and preference button are not reachable by keyboard when tabbing through the New Tab

Categories

(Firefox :: New Tab Page, defect, P2)

67 Branch
defect

Tracking

()

Firefox 68
Iteration:
71.1 - Sept 2 - 15

People

(Reporter: wolasi, Assigned: emcminn, NeedInfo)

References

(Blocks 2 open bugs)

Details

(Keywords: access)

Attachments

(1 file)

The search field and Preferences button should be reachable by keyboard when tabbing through the New Tab. See original version of New Tab for reference.

Iteration: --- → 68.4 - Apr 29 - May 12
Assignee: nobody → gsuntop

Hey Ricky, I think we discussed this a week or so back. Can you confirm that this is only going to be the case in Nightly as there is an experiment running to shift searches in the box up into the awesome bar? In other words, this is a known regression, but shouldn't affect Release?

Flags: needinfo?(rrosario)

(In reply to Gavin Suntop :gvn from comment #1)

Hey Ricky, I think we discussed this a week or so back. Can you confirm that this is only going to be the case in Nightly as there is an experiment running to shift searches in the box up into the awesome bar? In other words, this is a known regression, but shouldn't affect Release?

That's correct. This only affects Nightly since the search hand-off is Nightly-only until experiments are run.

Flags: needinfo?(rrosario)

Jess, should we wontfix this since it's just an experiment in Nightly and not a DS regression?

Flags: needinfo?(jdavis)

The caveat is: "until experiments are run". If the experiments are successful, then this behavior will ride the trains to Release.

I recommend we put this as a P3 into our backlog, and have it depend on search hand-off. Then if/when that bug gets movement, we'll know to pick this one back up. If someone has a better plan, please holler the recommendation here and we'll reassess.

Thanks!

Iteration: 68.4 - Apr 29 - May 12 → ---
Depends on: 1508388
Flags: needinfo?(jdavis)
Priority: P1 → P3

Sounds good! Unassigning myself for now so we can triage later.

Assignee: gsuntop → nobody
No longer blocks: pocket-newtab-69
No longer blocks: pocket-newtab-68
Blocks: 1554739
Keywords: access
Component: Activity Streams: Newtab → New Tab Page
Assignee: nobody → emcminn

Hey folks, is this okay to be worked on yet? It's the last non-keyboard-accessible element on Newtab so it would be cool to get it done :)

Flags: needinfo?(jdavis)
Flags: needinfo?(gsuntop)

Yes, feel free! Let me know if you have any Q's.

Flags: needinfo?(gsuntop)

(In reply to Gavin [:gvn] Suntop from comment #7)

Yes, feel free! Let me know if you have any Q's.

Hey Gavin, do you know if there was a reason the prefs button is rendered at the bottom of the html? This puts it right at the bottom of the tab order which is visually a little weird - you have to tab through the entire page before you can focus on the pref button, which is in the top corner.

I've moved it to the top of the render order in my PR, which makes it the second thing you tab to after the Search box. That feels right to me, but I wanted to double check that there wasn't some other reasoning for where it was. Thanks!

Flags: needinfo?(gsuntop)

Good catch Emily!
And yes, making it second in the tab order after Search should be fine.

(In reply to Wolasi :wolasi from comment #10)

Good catch Emily!
And yes, making it second in the tab order after Search should be fine.

Awesome, thank you!

thanks Emily, Gavin & Wolasi! \o/

Flags: needinfo?(jdavis)
Flags: needinfo?(gsuntop)
Iteration: --- → 70.4 - Aug 19 - Sep 1
Priority: P3 → P1

Yura, could you take a look at this PR and let me know if the tab behaviour is correct? Right now tab focuses the Search bar, and pressing Enter/Space triggers the cursor. Typing then moves focus up to the awesomebar. Ed and I weren't sure if this is correct, or if an Enter/Space press should move focus directly to the awesomebar.

Thanks!

https://github.com/mozilla/activity-stream/pull/5257#

Flags: needinfo?(yura.zenevich)
Iteration: 70.4 - Aug 19 - Sep 1 → 71.1 - Sept 2 - 15
Priority: P1 → P2

Kate - is this still valid now that https://github.com/mozilla/activity-stream/pull/5257# is closed?

Flags: needinfo?(khudson)
You need to log in before you can comment on or make changes to this bug.