Collect GEOLOCATION_REQUEST_GRANTED through 2019

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: tdsmith, Assigned: tdsmith)

Tracking

67 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 unaffected, firefox67 fixed, firefox68 fixed)

Details

Attachments

(2 attachments)

The GEOLOCATION_REQUEST_GRANTED probe expires in the next release. We're using this probe to target a survey, as in bug 1499851; new followup work that we're discussing now will also require the probe. Since we've extended collection a few times already, let's turn collection on indefinitely to avoid future busywork.

Previously, previously

The GEOLOCATION_REQUEST_GRANTED probe expires in the next release.
We're using this probe to target a survey, as in bug 1499851;
new followup work that we're discussing now will also require the probe.
Since we've extended collection a few times already, let's turn collection on indefinitely
to avoid future busywork.

Posted file Data collection review β€”
Attachment #9058375 - Flags: data-review?(mmccorquodale)
Version: 66 Branch → 67 Branch
Type: defect → enhancement
Comment on attachment 9058375 [details]
Data collection review

I discussed this with Megan and she preferred to have another steward look at it.
Attachment #9058375 - Flags: data-review?(mmccorquodale) → data-review?(chutten)
Comment on attachment 9058375 [details]
Data collection review

Preliminary note:

The only question is around a time-boxed study, but the request is for a permanent collection. Are there additional questions not captured in the request? Could we do with an expiring collection?

For permanent collections it is strongly recommended that you include a regression test ensuring that the collection doesn't break.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :tdsmith is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+, pending answers to preliminary notes
Flags: needinfo?(tdsmith)
Attachment #9058375 - Flags: data-review?(chutten) → data-review+

You're right; an expiring collection still makes sense. I updated the patch to collect until Firefox 72. Would you like a new data review request form to formalize the change?

Flags: needinfo?(tdsmith) → needinfo?(chutten)
Summary: Collect GEOLOCATION_REQUEST_GRANTED indefinitely → Collect GEOLOCATION_REQUEST_GRANTED through 2019
Attachment #9058372 - Attachment description: Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED indefinitely r?jdm → Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r?jdm

No, we're good with what's documented here.

Flags: needinfo?(chutten)
Pushed by tismith@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ca248347c5b
Collect GEOLOCATION_REQUEST_GRANTED through 2019 r=jdm
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9058372 [details]
Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r?jdm

Beta/Release Uplift Approval Request

  • User impact if declined: If declined, we won't be able to run a (newly-planned followup) survey project about geolocation during the next cycle.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a change to the expiry in the probe definition
  • String changes made/needed: none
Attachment #9058372 - Flags: approval-mozilla-beta?

Comment on attachment 9058372 [details]
Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r?jdm

Low risk, uplift approved for 67 beta 15, thanks.

Attachment #9058372 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.