1544542 - java.lang.NullPointerException: Attempt to invoke interface method 'void org.mozilla.geckoview.GeckoSession$HistoryDelegate.onHistoryStateChange(...)' on a null object reference

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

04-15 14:46:11.112 28514 28514 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke interface method 'void org.mozilla.geckoview.GeckoSession$HistoryDelegate.onHistoryStateChange(org.mozilla.geckoview.GeckoSession, org.mozilla.geckoview.GeckoSession$HistoryDelegate$HistoryList)' on a null object reference
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at org.mozilla.geckoview.GeckoSession$4.handleMessage(GeckoSession.java:613)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at org.mozilla.geckoview.GeckoSession$4.handleMessage(GeckoSession.java:588)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:78)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:368)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:873)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at android.os.Looper.loop(Looper.java:193)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6669)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
04-15 14:46:11.112 28514 28514 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

I get this in FxR, presumably because they don't hook up a history delegate.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1544542 - Don't try to call history delegate if we don't have one r?droeh

This also fixes a doc build issue.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1544542 - Don't try to call history delegate if we don't have one

This also fixes a doc build issue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eec26ba4a75
Don't try to call history delegate if we don't have one r=droeh

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1eec26ba4a75