Closed Bug 1544562 Opened 6 months ago Closed 6 months ago

aboutDialog-appUpdater's onUnload doesn't run in about:preferences

Categories

(Toolkit :: Application Update, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bytesized, Assigned: bytesized)

References

Details

Attachments

(1 file)

The onUnload function in aboutDialog-appUpdater.js is called when the about dialog is closed (from here), but it is never run when the code is loaded from about:preferences.

Attachment #9058407 - Attachment description: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong! → Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Attachment #9058407 - Attachment description: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong → Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong!
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/252732b54408
Call onUnload when about:preferences is closed r=rstrong
Regressions: 1544625
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Backed out for causing bug 1544625

Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=252732b54408cbf9de761baf469a03e55066a280

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=240518481&repo=autoland&lineNumber=5403

00:32:56 INFO - TEST-START | browser/components/preferences/in-content/tests/browser_security-1.js
00:33:00 INFO - GECKO(10260) | JavaScript warning: chrome://global/content/elements/tree.js, line 493: Array.forEach is deprecated; use Array.prototype.forEach instead
00:33:00 INFO - TEST-INFO | started process screenshot
00:33:00 INFO - TEST-INFO | screenshot: exit 0
00:33:00 INFO - Buffered messages logged at 00:32:56
00:33:00 INFO - Entering test bound setup
00:33:00 INFO - Buffered messages logged at 00:33:00
00:33:00 INFO - Leaving test bound setup
00:33:00 INFO - Entering test bound
00:33:00 INFO - Console message: [JavaScript Warning: "Array.forEach is deprecated; use Array.prototype.forEach instead" {file: "chrome://global/content/elements/tree.js" line: 493}]
00:33:00 INFO - Buffered messages finished
00:33:00 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_security-1.js | uncaught exception - TypeError: gAppUpdater is undefined at onUnload@chrome://browser/content/aboutDialog-appUpdater.js:23:7
00:33:00 INFO - handleEvent@chrome://browser/content/preferences/in-content/main.js:1440:9
00:33:00 INFO - EventListener.handleEventinit@chrome://browser/content/preferences/in-content/main.js:550:12
00:33:00 INFO - init@chrome://browser/content/preferences/in-content/preferences.js:64:22
00:33:00 INFO - async
initializeCategories@chrome://browser/content/preferences/in-content/findInPage.js:73:26
00:33:00 INFO - init/<@chrome://browser/content/preferences/in-content/findInPage.js:31:45
00:33:00 INFO - requestIdleCallback handlerinit@chrome://browser/content/preferences/in-content/findInPage.js:31:14
00:33:00 INFO - init_all@chrome://browser/content/preferences/in-content/preferences.js:89:22
00:33:00 INFO - EventListener.handleEvent
@chrome://browser/content/preferences/in-content/preferences.js:70:10
00:33:00 INFO -
00:33:00 INFO - Stack trace:
00:33:00 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1665
00:33:00 INFO - OnErrorEventHandlerNonNullchrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1645
00:33:00 INFO - chrome://mochikit/content/browser-test.js:Tester:402
00:33:00 INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:255
00:33:00 INFO - GECKO(10260) | JavaScript error: chrome://browser/content/aboutDialog-appUpdater.js, line 23: TypeError: gAppUpdater is undefined
00:33:00 INFO - Console message: [JavaScript Error: "TypeError: gAppUpdater is undefined" {file: "chrome://browser/content/aboutDialog-appUpdater.js" line: 23}]
00:33:00 INFO - onUnload@chrome://browser/content/aboutDialog-appUpdater.js:23:7
00:33:00 INFO - handleEvent@chrome://browser/content/preferences/in-content/main.js:1440:9
00:33:00 INFO - EventListener.handleEvent
init@chrome://browser/content/preferences/in-content/main.js:550:12
00:33:00 INFO - init@chrome://browser/content/preferences/in-content/preferences.js:64:22
00:33:00 INFO - asyncinitializeCategories@chrome://browser/content/preferences/in-content/findInPage.js:73:26
00:33:00 INFO - init/<@chrome://browser/content/preferences/in-content/findInPage.js:31:45
00:33:00 INFO - requestIdleCallback handler
init@chrome://browser/content/preferences/in-content/findInPage.js:31:14
00:33:00 INFO - init_all@chrome://browser/content/preferences/in-content/preferences.js:89:22
00:33:00 INFO - EventListener.handleEvent*@chrome://browser/content/preferences/in-content/preferences.js:70:10

Status: RESOLVED → REOPENED
Flags: needinfo?(ksteuber)
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---
Backout by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c29272019599
Backed out changeset 252732b54408 for causing bug 1544625 a=backout

This should be an easy fix. I'm on it.

Flags: needinfo?(ksteuber)
Attachment #9058407 - Attachment description: Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong! → Bug 1544562 - Call onUnload when about:preferences is closed r=rstrong
Blocks: 1544894
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be77d454cbe7
Call onUnload when about:preferences is closed r=rstrong
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.