Closed Bug 1544568 Opened 7 months ago Closed 7 months ago

cleanup how runtime libraries are built in build-clang

Categories

(Firefox Build System :: Toolchains, task)

task
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(4 files)

I had to write all these while trying to get arm64 linux fuzzing patches working; we might as well get these landed as a part of a separate bug.

The setup for compiler-rt is currently done before the stage 2 build,
which happens to be the final stage for our android runtime libraries
build. But we may also want to build runtime libraries on 3-stage
bootstrap builds, in which case we don't want compiler-rt to be active
for the second stage. Move the setup into build_one_stage so that the
setup is controllable by is_final_stage, which is set in all the place
that we care about.

We don't need them and we might as well be explicit about not building them.

Depends on D27592

android_targets here is a dict, not a sequence, and while iter on a
dict object implicitly means dict.iterkeys(), that's not really
obvious. We should instead be explicit about what we're doing here.

Depends on D27593

It seems better to set switches enabling runtime libraries and switches
enabling runtime libraries to build in different places, as future
changes might only enable runtime libraries for certain targets, but not
need any special switches for building.

Depends on D27594

Type: defect → task
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/536e9e448e98
move compiler-rt runtimes setup into build_one_stage; r=firefox-build-system-reviewers,chmanchester
https://hg.mozilla.org/integration/autoland/rev/0b0b2dc12c33
don't build XRay libraries; r=firefox-build-system-reviewers,chmanchester
https://hg.mozilla.org/integration/autoland/rev/e7174496ab2c
make setting of `LLVM_*_TARGETS` more explicit; r=firefox-build-system-reviewers,chmanchester
https://hg.mozilla.org/integration/autoland/rev/1427c70dc701
pull out runtime library-related settings in build-clang.py; r=firefox-build-system-reviewers,chmanchester
You need to log in before you can comment on or make changes to this bug.