1544573 - about:support copy text function copies hidden sections which show up when pasting in e.g. textedit

Status: VERIFIED FIXED

(Toolkit :: General, defect, P3)

Description

[:Gijs (he/him)]

There's a no-copy class, but the code at https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/toolkit/content/aboutSupport.js#968-971 just ignores it and copies the entire page contents. It also ignores it for text, but there perhaps the Serializer saves our bacon by ignoring hidden elements, or something.

As an example, this affects the "user.js Preferences
Your profile folder contains a user.js file, which includes preferences that were not created by Firefox." section (ie it shows up even if you don't have a user.js file).

Comment 1

[Alex Thayer [:alexical] (she/her)]

I'm not sure I'm seeing what you're seeing, or understand what this is referring to. I have clicked "Copy text to clipboard" and pasted in a text editor and all I see are things that show up in about:support and seem reasonable to copy out.

Could you clarify the STR?

Comment 2

[:Gijs (he/him)]

Yep! Steps from mac:

1. start with clean profile
2. open about:support
3. click 'copy text to clipboard'
4. open textedit.app and a new doc in there
5. ensure in the Format menu that rich text is enabled
6. paste in the new doc

I'm assuming that with these steps this is reproducible, though it'd be fun (for some meaning of the word) if you see something else. :-)

Comment 3

[Alex Thayer [:alexical] (she/her)]

Hmm, yeah I can reproduce this on Mac. I can't reproduce with pasting in WordPad on Windows, though. Given the importance of about:support pasting for bug reporting I'm going to P3 this.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1544573 - fix about:support copy/paste implementation to correctly ignore no-copy elements, r?dthayer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0943c0f7615
fix about:support copy/paste implementation to correctly ignore no-copy elements, r=dthayer

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d0943c0f7615

Comment 7

[Anca Soncutean, Desktop QA]

Reproduced: Fx 68.0a1 (2019-04-16) - Windows 10 x64
Verified fixed: Fx 69.0a1 (2019-06-05) and Fx 68.0b7 - Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13