Simplify the SPOC impression handling in DiscoveryStreamFeed

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P1
normal
RESOLVED FIXED
3 months ago
21 days ago

People

(Reporter: nanj, Assigned: nanj)

Tracking

({github-merged})

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Scott and I found that the current DISCOVERY_STREAM_SPOC_IMPRESSION handling in DSFeed involves some redundant processing that could be refactored out.

In particular, inside the DISCOVERY_STREAM_SPOC_IMPRESSION handler, we can get the current state of SPOCS from redux store other than the cache, and apply the SPOCS frequency capping without calling the transform(), finally dispatch the action to update the SPOCS in redux.

Type: defect → enhancement
Assignee: nobody → najiang
Keywords: github-merged
Iteration: --- → 68.3 - Apr 15 - 28
Priority: -- → P1
Blocks: 1546190
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Blocks: 1546535
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.