Closed Bug 1544584 Opened 5 months ago Closed 4 months ago

Make it possible to remove android.speech dependencies using Proguard

Categories

(GeckoView :: General, defect, P1)

All
Android
defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: imanol, Assigned: imanol)

Details

(Whiteboard: [geckoview:fxr:p1])

Attachments

(1 file)

Oculus VR store has a build validation proceess that blocks APKs which use android.speech dependencies.

We want to remove the dependency using Proguard in Firefox Reality. But GV keeps methods annotated with WrappedForJNI and that rule cannot be overriden from the main app including the GV aar.

Assignee: nobody → imanol

Some minor refactor to make it possible to remove android.speech dependencies using Proguard

Priority: -- → P1
Whiteboard: [geckoview:fxr:p1]

Randall says Oculus has whitelisted FxR for the android.speech issue, so we don't need to land this patch.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WORKSFORME

The whitelisting was on a one-time basis, and will not be ongoing. Let's work to get this landed. This is also a blocker for FxR v1.2 which is currently in release-candidate phase, so I would nominate for P0.

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b60e7b3407b3
Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay

Backed out changeset b60e7b3407b3 (bug 1544584) for Android Checkstyle in /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/SpeechSynthesisService.java

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246705184&repo=autoland&lineNumber=3059

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=246643582&revision=b60e7b3407b3aa6a2110f7e09a41e1ea10a04213

Backout:
https://hg.mozilla.org/integration/autoland/rev/317b7da2d8053c65bb905ab79f8226563b6538ca

Flags: needinfo?(imanol)
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97c7af33ac1d
Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay
Status: REOPENED → RESOLVED
Closed: 5 months ago4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(imanol)
You need to log in before you can comment on or make changes to this bug.