1544584 - Make it possible to remove android.speech dependencies using Proguard

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Imanol Fernandez]

Oculus VR store has a build validation proceess that blocks APKs which use android.speech dependencies.

We want to remove the dependency using Proguard in Firefox Reality. But GV keeps methods annotated with WrappedForJNI and that rule cannot be overriden from the main app including the GV aar.

Comment 1

[Imanol Fernandez]

Attachment: Bug 1544584 - Make it possible to remove android.speech dependencies using Proguard

Some minor refactor to make it possible to remove android.speech dependencies using Proguard

Comment 2

[Chris Peterson [:cpeterson]]

Randall says Oculus has whitelisted FxR for the android.speech issue, so we don't need to land this patch.

Comment 3

[Philip Lamb]

The whitelisting was on a one-time basis, and will not be ongoing. Let's work to get this landed. This is also a blocker for FxR v1.2 which is currently in release-candidate phase, so I would nominate for P0.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b60e7b3407b3
Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset b60e7b3407b3 (bug 1544584) for Android Checkstyle in /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/SpeechSynthesisService.java

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246705184&repo=autoland&lineNumber=3059

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=246643582&revision=b60e7b3407b3aa6a2110f7e09a41e1ea10a04213

Backout:
https://hg.mozilla.org/integration/autoland/rev/317b7da2d8053c65bb905ab79f8226563b6538ca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97c7af33ac1d
Make it possible to remove android.speech dependencies using Proguard r=snorp,rbarker,eeejay

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/97c7af33ac1d