1544610 - Have cert error captive portal message exchanges happen over RPM

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[:prathiksha]

We currently addMessageListeners in browser.js[0] to handle cert error events coming from the child/content process. This bug aims to replace this way of handling events by using the remote page manager to sandbox about:certerror events and improve code maintainability.

[0] https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/browser/base/content/browser.js#3028-3037

Comment 1

[:prathiksha]

Attachment: Bug 1544610 - Part 1 - Have certerror captive portal message exchanges happen over RPM. r?johannh

Have certerror captive portal message exchanges happen over RPM.

Comment 2

[:prathiksha]

Attachment: Bug 1544610 - Part 2 - Have CertExceptionError message exchanges happen over RPM. r?johannh

Depends on D28539

Comment 3

[:prathiksha]

Attachment: patch.txt

A patch for exposing nsITransportSecurityInfo to unprivileged content.

Comment 4

[Lina Butler (ex-Mozilla)]

The error Prathiksha saw was "Permission denied for <about:certerror> to create wrapper for object of class UnnamedClass".

Comment 5

[Andrea Marchesini [:baku]]

It seems that it's not possible to use xpcom interfaces for non-chrome code in WebIDL. I think that, the best solution is to expose a webidl dictionary with the data you care, taken from nsIransportSecurityInfo.

Comment 6

[Andrea Marchesini [:baku]]

Just to give an example about how to use a WebIDL dictionary and expose it to content

Here we have the definition of AutocompleteInfo:
https://searchfox.org/mozilla-central/rev/b4e790d05f5a146d186c238bac5601a553581d23/dom/webidl/AutocompleteInfo.webidl

Which is exposed here:
https://searchfox.org/mozilla-central/rev/b4e790d05f5a146d186c238bac5601a553581d23/dom/webidl/HTMLSelectElement.webidl#72

and it's set here:
https://searchfox.org/mozilla-central/rev/b4e790d05f5a146d186c238bac5601a553581d23/dom/base/nsContentUtils.cpp#919-922

But there are many other examples. Important note: a dictionary cannot be exposed as attribute. Just make it as a return type of a method.

Comment 7

[Johann Hofmann [:johannh]]

Thanks Baku :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df46098ba4b5
Part 1 - Have certerror captive portal message exchanges happen over RPM. r=johannh

Comment 9

[:prathiksha]

Changing this bug description to track captive portal message exchanges between content and parent processes over RPM. I will be filing more bugs to track replacing other certerror/neterror message exchanges (see comment 0 [0]) with RPM.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/df46098ba4b5