Closed Bug 1544673 Opened 6 years ago Closed 6 years ago

Stack traces when running moz-phab without arc

Categories

(Conduit :: moz-phab, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1544727

People

(Reporter: pbone, Unassigned)

Details

moz-phab can install arc when it's not found in the path. But when it does so it's noisy with some python stack traces:

$ moz-phab -h 
Installing arc
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/__init__.py", line 868, in emit
    msg = self.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 741, in format
    return fmt.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
    record.message = record.getMessage()
  File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Logged from file moz-phab, line 2233
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/__init__.py", line 868, in emit
    msg = self.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 741, in format
    return fmt.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
    record.message = record.getMessage()
  File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
    msg = msg % self.args
TypeError: not all arguments converted during string formatting
Logged from file moz-phab, line 2234
Cloning into '/home/paul/.mozbuild/moz-phab/arcanist'...
remote: Enumerating objects: 1129, done.
remote: Counting objects: 100% (1129/1129), done.
remote: Compressing objects: 100% (864/864), done.
remote: Total 1129 (delta 191), reused 854 (delta 157), pack-reused 0
Receiving objects: 100% (1129/1129), 757.76 KiB | 775.00 KiB/s, done.
Resolving deltas: 100% (191/191), done.
Cloning into '/home/paul/.mozbuild/moz-phab/libphutil'...
remote: Enumerating objects: 1017, done.
remote: Counting objects: 100% (1017/1017), done.
remote: Compressing objects: 100% (878/878), done.
remote: Total 1017 (delta 110), reused 517 (delta 69), pack-reused 0
Receiving objects: 100% (1017/1017), 1.75 MiB | 1.79 MiB/s, done.
Resolving deltas: 100% (110/110), done.
usage: moz-phab [-h] COMMAND ...

optional arguments:
  -h, --help           show this help message and exit

subcommands:
  For full command description: moz-phab COMMAND -h

  COMMAND
    submit             Submit commits(s) to Phabricator
    self-update        Update review script
    patch              Patch from Phabricator revision
    install-certificate
                       Install Phabricator certificate locally
    arc                Call Arcanist
paul@phosphorus ~ $ moz-phab -h 
usage: moz-phab [-h] COMMAND ...

optional arguments:
  -h, --help           show this help message and exit

subcommands:
  For full command description: moz-phab COMMAND -h

  COMMAND
    submit             Submit commits(s) to Phabricator
    self-update        Update review script
    patch              Patch from Phabricator revision
    install-certificate
                       Install Phabricator certificate locally
    arc                Call Arcanist

i stumbled across this while fixing bug 1544727, and fixed it in that patch.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.