Closed Bug 1544680 Opened 1 year ago Closed 1 year ago

Use :root instead of #main-window in browser/themes/osx/browser.css

Categories

(Firefox :: Theme, task, P3)

All
macOS
task

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: dao, Assigned: MonikaMaheshwari, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1543043 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/osx/browser.css there are currently five selectors that should use :root instead of #main-window.

See Also: → 1543043, 1542187, 1541799, 1292878
Type: defect → task

Hi, can I work on this issue.

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #3)

Hi, can I work on this issue.

Absolutely. Please let me know if you have questions.

Attachment #9064240 - Attachment description: Bug 1544680 Use :root instead of #main-window in browser/themes/osx/browser.css → Bug 1544680 - Use :root instead of #main-window in browser/themes/osx/browser.css
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b97ebad61562
Use :root instead of #main-window in browser/themes/osx/browser.css r=dao
Assignee: nobody → monikamaheshwari1996
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
See Also: → 1554609
See Also: → 1561552
You need to log in before you can comment on or make changes to this bug.