Closed
Bug 1544680
Opened 5 years ago
Closed 5 years ago
Use :root instead of #main-window in browser/themes/osx/browser.css
Categories
(Firefox :: Theme, task, P3)
Tracking
()
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: dao, Assigned: MonikaMaheshwari, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1543043 +++
:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
In browser/themes/osx/browser.css there are currently five selectors that should use :root instead of #main-window.
|
Reporter | |
Updated•5 years ago
|
Type: defect → task
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
Assignee | |
Comment 3•5 years ago
|
||
Hi, can I work on this issue.
|
|
Reporter | |
Comment 4•5 years ago
|
||
(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #3)
Hi, can I work on this issue.
Absolutely. Please let me know if you have questions.
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9064240 -
Attachment description: Bug 1544680 Use :root instead of #main-window in browser/themes/osx/browser.css → Bug 1544680 - Use :root instead of #main-window in browser/themes/osx/browser.css
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b97ebad61562 Use :root instead of #main-window in browser/themes/osx/browser.css r=dao
|
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → monikamaheshwari1996
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•