Closed Bug 1544684 Opened 5 months ago Closed 5 months ago

Contrast filter is not revoked after selecting a text leaf that passes contrast check

Categories

(DevTools :: Accessibility Tools, defect)

defect
Not set

Tracking

(firefox68 verified)

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: tbabos, Assigned: yzen)

References

Details

Attachments

(2 files)

Attached video Video of the issue

Affected versions:
Nightly 68.0a1 68.0a1 (2019-04-11) (64-bit) - TRY BUILD - 20190411095057

Affected platform:
Windows 10 - so far

Steps to reproduce:

  • Go to any site with failed contrast check elements, ex: https://twitter.com/
  • Enable Accessibility in devtools
  • Click on the "contrast" button to perform a full page contrast audit
  • Take the accessible object picker and select a text leaf that passes the contrast ratio check

Expected Result:
The filter should be revoked and the proper text leaf element should be highlighted in the expanded a11y tree.

Actual Result:
The filtered a11y tree is still displayed and the first text leaf from the tree is highlighted.

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1455fb3278d1
reset filters when a new accessible is selected. r=gl

I submitted a patch that resets the filters if any accessible is selected. Failing (filtered in) or not (filtered out).

Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Verified - Fixed on latest Nightly on Windows 10, Mac OS 10.14 and Ubuntu 18.04.
Selecting a text leaf with the accessible object tool with either good or bad contrast will revoke the filtered tree view and highlight in the a11y tree the selected element.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.