Add support for custom threads for Gecko profiler
Categories
(Testing :: Raptor, task, P1)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
For video streaming tests as to be implemented on bug 1539111 we also want to create Gecko profiles while running the tests. To activate the media specific markers the custom "MediaPlayback" thread has to be added before starting the profile.
Right now threads are selected in the WebExt of Raptor:
https://searchfox.org/mozilla-central/source/testing/raptor/webext/raptor/runner.js#314-317
I would suggest that we don't hard-code those threads in the web extension but instead make it configurable for the tests. As such we could also let the Raptor Python code set the "WR,Renderer" thread automatically based on the type of build.
test_settings['raptor-options']['webrender_enabled'] = True
vs.
test_settings['raptor-options']['gecko_profile_threads'].append('WR,Renderer')
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Note that with this patch I also supply a fix for correctly setting the gecko profiler entries and interval. Right now those always fallback to the default values. Also setting the extra threads for WebRender are wrong.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
When the Gecko profiler is enabled the interval and entries as specified
in manifest files aren't correctly set. Instead the default values from
the extension are always used.
Also with WebRender enabled the threads are "WR", and "Renderer", but
not "WR,Renderer".
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D28045
|
|
Assignee | |
Comment 7•5 years ago
|
||
Depends on D28046
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ff6837b1526 [raptor] Fix Gecko profiler settings. r=rwood https://hg.mozilla.org/integration/autoland/rev/201fb70499ef [raptor] Make Gecko profiler threads customizable in the harness. r=rwood https://hg.mozilla.org/integration/autoland/rev/50b7f764f4af [raptor] Allow CLI arguments to override Gecko profiler settings from test manifest. r=perftest reviewers,rwood
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ff6837b1526
https://hg.mozilla.org/mozilla-central/rev/201fb70499ef
https://hg.mozilla.org/mozilla-central/rev/50b7f764f4af
|
|
Assignee | |
Comment 10•5 years ago
|
||
I just added some documentation for this feature:
https://wiki.mozilla.org/Performance_sheriffing/Raptor#Customizing_the_profiler
Description
•