Global DevTools shortcuts are broken when running in frame with type=content

RESOLVED FIXED in Firefox 68

Status

enhancement
P2
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

unspecified
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Split from Bug 1543940.

Fixing keyboard shortcuts in frames with type=content can be done independently of the work on context menu.

STRs:

  • set content="type" for devtools frames (in toolbox-hosts::createDevToolsFrame() add frame.setAttribute("type", "content");)
  • some shortcuts are no longer working. eg:
    • select a node in markup-view
    • press search shortcut (cmd+F on osx)
      ER: Inspector search is focused
      AR: Browser search is started and focused

We need to rely on the chromeEventHandler from the toolbox to fix this.

Depends on D27672

Will be used both for shortcuts and contextmenu events in the toolbox.

Blocks: 1543940
Depends on: 1544749

Depends on D27683
As we will move shortcuts to use chromeEventHandler as their target, we need an easy way to add and remove them on host switch.
The chromeEventHandler will change when switching from window to docked hosts (and vice versa)

Depends on D27686
Toolbox, zoom keys and inspector search should use the chromeeventhandler as event target.
They need to capture events from inner frames.

Type: defect → enhancement
Attachment #9058570 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d4a1d1d3b7f
Move all shortcuts registration for toolbox in addShortcuts method r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fa356a2cccc6
Use chromeEventHandler for splitConsole events r=ochameau
https://hg.mozilla.org/integration/autoland/rev/1b7dc4afb065
Register global keyboard shortcuts on chromeEventHandler r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.