1544710 - Deactivating filtering ends up at the top of the tree

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, defect, P1)

Description

[Martin Balfanz [:mbalfanz]]

STR:

• go to a website and run the contrast audit
• select an item from the resulting node list
• deactivate the filter, e.g. by clicking the badge of the selected item

AR:

• Accessibility tree has the right node selected, but is scrolled up to the top

ER:

• Accessibility tree has the right node selected and should be scrolled in a position where the selected node is visible

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

We should check that the selected row is properly scrolled into view. Revisit changes that were done in the TreeView component for scrolling and check if custom AccessibilityRow scrolling into view can be removed.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Moving to P1 as identified by QA

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1544710 - ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/082c0dba73cb
ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley

Comment 5

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 082c0dba73cb (Bug 1544710) for causing dt permafailures in devtools/client/netmonitor/test/browser_net_propertiesview-copy.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=a8fcad5870bad1bc7d9b355e2b3348753f7385c7&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&selectedJob=244151642

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244151642&repo=autoland&lineNumber=3534

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f81b6439ae4e
Backed out changeset 082c0dba73cb for causing dt permafailures in devtools/client/netmonitor/test/browser_net_propertiesview-copy.js CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66c1e6f5276f
ensure that selected row is always visible within TreeView after update. Clean up scroll into view operations across all uses of TreeView. r=mtigley

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/66c1e6f5276f

Comment 9

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on Windows 10, Mac OS 10.14 and Ubuntu 16.04 using the builds from: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=244478427