Update GNOME shell service

RESOLVED FIXED in seamonkey2.65

Status

defect
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

(Blocks 1 bug)

Trunk
seamonkey2.65
All
Linux
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Details

Attachments

(9 attachments)

Assignee

Description

2 months ago

Bring SeaMonkey's GNOME shell service more inline with Firefox's version.

  • Use nsAutoCString instead of const char* for desktop wallpaper filling style
  • Use kDesktop* defines rather than OGDB_* ones
  • Add GetAppPathFromLauncher helper
  • Change helper from HandlerMatchesAppName to CheckHandlerMatchesAppName and rework
  • Add extra file extensions
  • Add essential parameter to protocol association and rework IsDefaultClient / SetDefaultClient
  • Add WriteImage helper and rework SetDesktopBackground
  • Port Bug 1368211 - Don't create gnome shell service in headlesss mode
  • Tidy up Get/SetDesktopBackgroundColor
Assignee

Comment 2

2 months ago
Assignee

Comment 5

2 months ago
Assignee

Comment 6

2 months ago
Assignee

Comment 7

2 months ago
Assignee

Updated

2 months ago
Attachment #9058539 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058542 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058697 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058827 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058941 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058942 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058961 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058966 - Flags: review?(frgrahl)
Assignee

Updated

2 months ago
Attachment #9058979 - Flags: review?(frgrahl)
Comment on attachment 9058942 [details] [diff] [review]
Part f - add essential parameter

IanN, I think we missed additional parts from Bug 1297686 in Bug 1544222. 

I don't see the handlers in the prefs. Could you check if we need updates in 
common/pref/pref-applications.js maybe for a follow-up bug.
Blocks: 1036903

Comment 11

2 months ago

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/518ab6433e07
Part 1: Update GNOME shell service - Change wallpaper fill from char to nsAutoCString. r=frg
https://hg.mozilla.org/comm-central/rev/1d4b0bed5c3c
Part 2: Update GNOME shell service - Change from using OGDB_* to kDesktop* defines. r=frg
https://hg.mozilla.org/comm-central/rev/62f522465ec6
Part 3: Update GNOME shell service - Add GetAppPathFromLauncher helper. r=frg
https://hg.mozilla.org/comm-central/rev/bc9429cb532b
Part 4: Update GNOME shell service - Change to CheckHandlerMatchesAppName. r=frg
https://hg.mozilla.org/comm-central/rev/a5ae416f6f2a
Part 5: Update GNOME shell service - Add extra extensions. r=frg a=frg
https://hg.mozilla.org/comm-central/rev/ff8f98e85183
Part 6: Update GNOME shell service - Add essential parameter to protocol association. r=frg
https://hg.mozilla.org/comm-central/rev/6dcc615519cb
Part 7: Update GNOME shell service - Add WriteImage helper. r=frg
https://hg.mozilla.org/comm-central/rev/4839cd67be0d
Part 8: Update GNOME shell service - Don't create gnome shell service in headlesss mode. r=frg a=frg
https://hg.mozilla.org/comm-central/rev/cf9589555bdd
Part 9: Update GNOME shell service - Sync Get/SetDesktopBackgroundColor. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Type: enhancement → defect
Target Milestone: --- → seamonkey2.65
Attachment #9058539 - Flags: review?(frgrahl)
Attachment #9058539 - Flags: review+
Attachment #9058539 - Flags: approval-comm-esr60+
Attachment #9058542 - Flags: review?(frgrahl)
Attachment #9058542 - Flags: review+
Attachment #9058542 - Flags: approval-comm-esr60+
Attachment #9058697 - Flags: review?(frgrahl)
Attachment #9058697 - Flags: review+
Attachment #9058697 - Flags: approval-comm-esr60+
Attachment #9058827 - Flags: review?(frgrahl)
Attachment #9058827 - Flags: review+
Attachment #9058827 - Flags: approval-comm-esr60+
Attachment #9058941 - Flags: review?(frgrahl)
Attachment #9058941 - Flags: review+
Attachment #9058941 - Flags: approval-comm-esr60+
Comment on attachment 9058942 [details] [diff] [review]
Part f - add essential parameter

>  for (unsigned i = 0; i < mozilla::ArrayLength(gProtocols); i++) {
> +  for (unsigned int i = 0; i < ArrayLength(gProtocols); i++) {

c-c uses namespace mozilla. Older branches not. Adjusted for both. We should probably align this in a follow-up for esr60 only. I think esr60 can already be switched to the namespace.
Attachment #9058942 - Flags: review?(frgrahl)
Attachment #9058942 - Flags: review+
Attachment #9058942 - Flags: approval-comm-esr60+
Comment on attachment 9058961 [details] [diff] [review]
Part g - add WriteImage helper

> +#  include "nsIImageToPixbuf.h"

Aligned the included with the Fx one in browser for checkin. Alignment looked better but otherwise a little non standard. Can fix it if you prefer the first version.
Attachment #9058961 - Flags: review?(frgrahl)
Attachment #9058961 - Flags: review+
Attachment #9058961 - Flags: approval-comm-esr60+
Comment on attachment 9058966 [details] [diff] [review]
Part h - no gnome shell when headless

Currently not used I think.
Attachment #9058966 - Flags: review?(frgrahl)
Attachment #9058966 - Flags: review+
Attachment #9058966 - Flags: approval-comm-esr60+
Attachment #9058979 - Flags: review?(frgrahl)
Attachment #9058979 - Flags: review+
Attachment #9058979 - Flags: approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.