1544739 - Update GNOME shell service

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[Ian Neal]

Bring SeaMonkey's GNOME shell service more inline with Firefox's version.

• Use nsAutoCString instead of const char* for desktop wallpaper filling style
• Use kDesktop* defines rather than OGDB_* ones
• Add GetAppPathFromLauncher helper
• Change helper from HandlerMatchesAppName to CheckHandlerMatchesAppName and rework
• Add extra file extensions
• Add essential parameter to protocol association and rework IsDefaultClient / SetDefaultClient
• Add WriteImage helper and rework SetDesktopBackground
• Port Bug 1368211 - Don't create gnome shell service in headlesss mode
• Tidy up Get/SetDesktopBackgroundColor

Comment 1

[Ian Neal]

Attachment: Part a - change from char to nsAutoCString

Comment 2

[Ian Neal]

Attachment: Part b - change to kDesktop defines

Comment 3

[Ian Neal]

Attachment: Part c - add GetAppPathFromLauncher helper

Comment 4

[Ian Neal]

Attachment: Part d - change to CheckHandlerMatchesAppName

Comment 5

[Ian Neal]

Attachment: Part e - add extra file extensions

Comment 6

[Ian Neal]

Attachment: Part f - add essential parameter

Comment 7

[Ian Neal]

Attachment: Part g - add WriteImage helper

Comment 8

[Ian Neal]

Attachment: Part h - no gnome shell when headless

Comment 9

[Ian Neal]

Attachment: Part i - tidy up Get/SetDesktopBackgroundColor

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9058942 [details] [diff] [review]
Part f - add essential parameter

IanN, I think we missed additional parts from Bug 1297686 in Bug 1544222. 

I don't see the handlers in the prefs. Could you check if we need updates in 
common/pref/pref-applications.js maybe for a follow-up bug.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/518ab6433e07
Part 1: Update GNOME shell service - Change wallpaper fill from char to nsAutoCString. r=frg
https://hg.mozilla.org/comm-central/rev/1d4b0bed5c3c
Part 2: Update GNOME shell service - Change from using OGDB_* to kDesktop* defines. r=frg
https://hg.mozilla.org/comm-central/rev/62f522465ec6
Part 3: Update GNOME shell service - Add GetAppPathFromLauncher helper. r=frg
https://hg.mozilla.org/comm-central/rev/bc9429cb532b
Part 4: Update GNOME shell service - Change to CheckHandlerMatchesAppName. r=frg
https://hg.mozilla.org/comm-central/rev/a5ae416f6f2a
Part 5: Update GNOME shell service - Add extra extensions. r=frg a=frg
https://hg.mozilla.org/comm-central/rev/ff8f98e85183
Part 6: Update GNOME shell service - Add essential parameter to protocol association. r=frg
https://hg.mozilla.org/comm-central/rev/6dcc615519cb
Part 7: Update GNOME shell service - Add WriteImage helper. r=frg
https://hg.mozilla.org/comm-central/rev/4839cd67be0d
Part 8: Update GNOME shell service - Don't create gnome shell service in headlesss mode. r=frg a=frg
https://hg.mozilla.org/comm-central/rev/cf9589555bdd
Part 9: Update GNOME shell service - Sync Get/SetDesktopBackgroundColor. r=frg

Comment 12

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9058942 [details] [diff] [review]
Part f - add essential parameter

>  for (unsigned i = 0; i < mozilla::ArrayLength(gProtocols); i++) {
> +  for (unsigned int i = 0; i < ArrayLength(gProtocols); i++) {

c-c uses namespace mozilla. Older branches not. Adjusted for both. We should probably align this in a follow-up for esr60 only. I think esr60 can already be switched to the namespace.

Comment 13

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9058961 [details] [diff] [review]
Part g - add WriteImage helper

> +#  include "nsIImageToPixbuf.h"

Aligned the included with the Fx one in browser for checkin. Alignment looked better but otherwise a little non standard. Can fix it if you prefer the first version.

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9058966 [details] [diff] [review]
Part h - no gnome shell when headless

Currently not used I think.

Comment 15

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/pushloghtml?changeset=33e9c7be67682a74b1558f4fc474f64ad003de7c