1544749 - Update DevTools code relying on toolbox.win.parent or toolbox.win.top

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Julian Descottes [:jdescottes]]

In Bug 1539979 we want to use a frame with type=content to load DevTools. After that change we can no longer use win.top or win.parent to reach the Chrome window parent of the toolbox window. Instead we should use the topWindow getter on the toolbox (or rely on the same logic in case the toolbox object is not available)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1544749 - Add shared helper to retrieve the top window

Some classes in DevTools will not have an easy way to get access to the toolbox.
However they might still want to use the topmost chrome window.
Extract the logic from toolbox.js to a shared helper.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1544749 - Fix HTML Tooltip tests when running in content frame

Depends on D27672

Not strictly related to win.top/parent, but those tests would fail if the toolbox is in a content frame.
tooltip-01.js is creating a blank tab for no reason which prevents interacting with the actual test frame.
tooltip-02.js is not properly targeting an iframe to simulate a click

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1544749 - Animation inspector scrubber should use getTopWindow

Depends on D27674

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1544749 - Sidebar iframe onload callback should not rely on event.target

Depends on D27675
The target of the iframe load event is the content document when running in frame with type=chrome.
When running in frame with type=content, the target will be the iframe element itself.
Stop relying on event.target so that the Sidebar can work in both cases

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1544749 - Use toolbox.topWindow in devtools tests relying on toolbox.win.top/parent

Depends on D27677
Update tests directly referencing toolbox.win.top/parent.

Comment 6

[Julian Descottes [:jdescottes]]

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ab3ba6dc624a606ba139a1df0744515b0712496

I tried to extract all the minor changes that could land regardless of the frame's type, and not related to one of bigger tracks (contextmenus, shortcuts or webextensions).

Comment 7

[Julian Descottes [:jdescottes]]

Updated try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f406e478fe2937dea3a669f26e866d8ddd0cdc3c

Comment 8

[Julian Descottes [:jdescottes]]

Will reorder the patch + leave-open to start landing things here.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46afb0a8df4b
Add shared helper to retrieve the top window r=bgrins
https://hg.mozilla.org/integration/autoland/rev/ad0f4d97dd1e
Animation inspector scrubber should use getTopWindow r=daisuke
https://hg.mozilla.org/integration/autoland/rev/f71f9d2fa72b
Sidebar iframe onload callback should not rely on event.target r=daisuke
https://hg.mozilla.org/integration/autoland/rev/51423343879f
Use toolbox.topWindow in devtools tests relying on toolbox.win.top/parent r=daisuke

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/46afb0a8df4b
https://hg.mozilla.org/mozilla-central/rev/ad0f4d97dd1e
https://hg.mozilla.org/mozilla-central/rev/f71f9d2fa72b
https://hg.mozilla.org/mozilla-central/rev/51423343879f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/970ef36e6c09
Fix HTML Tooltip tests when running in content frame r=bgrins

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/970ef36e6c09