Closed Bug 1544752 Opened 5 years ago Closed 5 years ago

Fix old performance panel test failures when running in frame with type=content

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Some old performance panel tests still seem to be failing when loading DevTools in a frame with type=content:

STRs:

  • set content="type" for devtools frames (in toolbox-hosts::createDevToolsFrame() add frame.setAttribute("type", "content");)
  • devtools/client/performance/test/browser_perf-overview-render-04.js fails because we try to call setTheme on a non-initialized graph

When fixing the issue for the previous test, devtools/client/performance/test/browser_perf-overview-render-02.js starts failing intermittently

Component: General → Performance Tools (Profiler/Timeline)

Not exactly sure why, but this doesn't showup anymore in my last try pushes. Closing for now.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.