154482 - Checking none of the checkboxes in the "Email Addresses, Bug Numbers, and Votes" section of query.cgi shouldn't throw an error

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[timeless]

You must specify one or more fields in which to search for timeless.

The error should either be non fatal, or it should clearly indicate which field 
messed up, since i have two fields with the same string.

Comment 1

[timeless]

Attachment: stop erroring

Comment 2

[Frédéric Buclin]

joel, can you have a look at this patch?

Comment 4

[Frédéric Buclin]

Comment on attachment 215136 [details] [diff] [review]
stop erroring

Not only the buglist you get silently ignores this mistake, which is highly confusing, but runtests.pl -v 12 now throws a warning about missing_email_type being no longer used.

Comment 5

[[e-mail]]

I don't think it's a mistake. In fact, I think it makes just as much (or little) sense to default the check boxes on without providing an email address.

I have my email address predefined in my default search parameters, since I'm often looking for a bug that I commented on. It's a pain having to go back and delete it every time that I forget when I don't want to search for myself.

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> I don't think it's a mistake. In fact, I think it makes just as much (or
> little) sense to default the check boxes on without providing an email address.

Hum, yes, you're right. I changed my mind about this behavior. Patch fixing the warning in runtests.pl coming in a few seconds.

Comment 7

[Frédéric Buclin]

Attachment: patch, v2

Comment 8

[Max Kanat-Alexander]

Comment on attachment 364973 [details] [diff] [review]
patch, v2

Yeah, that seems fine to me.

Comment 9

[Max Kanat-Alexander]

This is a behavior change, so let's limit it to 3.4.

Comment 10

[Frédéric Buclin]

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.172; previous revision: 1.171
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <-- user-error.html.tmpl
new revision: 1.276; previous revision: 1.275
done