1544866 - Make InterSliceGCRunnerFired to return false in case the full budget wasn't used.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

IdleTaskRunner keeps dispatching to idle queue if callback tells work has been done. But close to the end of GC we do the last foreground sweep slice and then
basically poll background tasks to finish. We don't want those polling to be marked as "work done", since we just keep dispatching IdleTaskRunner to idle queue in a loop.

Patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1544866 - Make InterSliceGCRunnerFired to return false in case the full budget wasn't used. r=sfink

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Sounds like we need some new API to GC after all.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b674f733df77
Make InterSliceGCRunnerFired to return false in case the full budget wasn't used. r=sfink

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bot thinks this bug is a task, but please change it back in case of error.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

No idea what is the difference between defect, task and enhancement :)
This feels perhaps most enhancement.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b674f733df77