154501 - IMAP drafts folder not being created when saving Drafts - this is the default

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[esther]

Using branch build 20020626branch on winxp and linux (haven't tested mac yet) we
are not creating a Drafts or Template folder for IMAP accounts if needed when
saving as Draft or Template.  Result is we get and error when trying to save a
Draft or Template.  Our default is to set the Draft and Template location to the
IMAP folder so we should create it if it's not there.
Regression, not sure when it broke I will find out.

Setup (remove your drafts and template folders from an IMAP account you have so
when you add that IMAP account to a new profile they don't show up in the Folder
pane for the IMAP account)
1. Launch app
2. Add this IMAP account to mail
3. Log into the IMAP account giving correct password
4. Compose a message and save as draft

Result: error message about incorrect setting for Drafts
Expected: Drafts folder created and draft sent to it.

Comment 1

[esther]

nominating, regression and because of this bad user experience for saving drafts
and templates.

Comment 2

[scottputterman]

reassigning to Cavin.  Can you look into this today?  

Comment 3

[Cavin Song]

Yes, this is a regression. I ran the one from last December and it would create 
the server Drafts/Templates folder first before saving the msg to the folder.

Comment 4

[Cavin Song]

Looks like it could be the fix to bug 90064 broke this one in function 
LocateMessageFolder() of nsMsgCopy.cpp. That patch was submitted on 06/04/02 and 
the 05/23/02 build still works fine. Still verifying.

Comment 5

[esther]

Update: the 6-14 branch build worked for me on linux.  Also note: not only will
it not create these folders for you, you can't create them manually, you get an
error that the folder already exists.

Comment 6

[Cavin Song]

Clarification:

Patch of bug 90064 was checked in to the trunk on 06/04/02 and to the branch on 
06/19/02.

Comment 7

[Navin Gupta]

I'll take a look. I was in this code recently. 

Comment 8

[Navin Gupta]

I have broken it so I should fix it. 

Comment 9

[Navin Gupta]

Attachment: proposed fix

The fix is to pass the dummy folder because we create missing/new folder based
on that in CreateIfMissing.

Comment 10

[Navin Gupta]

Cavin, David, Can I get reviews ? thx. 

Comment 11

[David :Bienvenu]

Comment on attachment 89475 [details] [diff] [review]
proposed fix

sr=bienvenu

Comment 12

[esther]

Reminder, this bug should include the Template folder too.

Comment 13

[Navin Gupta]

yes, it fixes templates folder also. 

Comment 14

[scottputterman]

Let's get this checked in after the r= and verified on tomrrow's trunk build. 
Esther, can you do the verification?

Comment 15

[Cavin Song]

Comment on attachment 89475 [details] [diff] [review]
proposed fix

r=cavin.

Comment 16

[Navin Gupta]

fixed on trunk.

Comment 17

[esther]

Yes, I'll test it on the trunk 6-28 am

Comment 18

[scottputterman]

any verification results?

Comment 19

[esther]

So far linux and mac 9.1 are ok.  I tested this scenario and the scenario in the
bug that was fixed. However, QA never saw the problem reported in 90064 bringing
up a subscribe error, so all I could do is run the scenario to make sure it
still brings up the login dialog for Coyping the sent message to the IMAP sent
folder.  Still need to verify on windows and mac os 10.1

Comment 20

[esther]

Win 98 OK too. Still need to test MAC OS10.1

Comment 21

[esther]

OK this is ready to go, will verify for trunk.  

Comment 22

[esther]

Just to avoid confusion by my previous comment.  This is verified on trunk,
ready for branch check in.

Comment 23

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 24

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 25

[Navin Gupta]

fixed on branch

Comment 26

[Olga]

I verified it on Mac OSX, today's build. 
Folders are created as expected when save as Draft or Template.

Comment 27

[Olga]

I forgot to mentioned that tested with regular IMAP and Web Mail account.

Comment 28

[esther]

Using branch build 20020703 on linux, mac 9.1 and winxp this is fixed.  The
sent, template and draft folder is created when needed if there is not one. 
Also the webmail draft folder now works with this fix.