[remote-dbg-next] Make the connection error message on sidebar to be closable

VERIFIED FIXED in Firefox 68

Status

defect
P1
normal
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: daisuke, Assigned: ogasidlo)

Tracking

(Blocks 1 bug)

unspecified
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 verified)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(1 attachment)

This is a followup of bug 1540609.

Including above bug, we show some connection error messages. However those messages can not close by user. In this bug, make the messages to be closable by user.

After https://phabricator.services.mozilla.com/D27645 lands, this should be a quick fix.
Please add isClosable: true, to all message components that need a closing button.

e.g.
here: https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js#79

https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js#104

Regarding this patch, we also need to update following function with the additional parameter:

renderMessage(flag, level, localizationId, className) {...} renderMessage(flag, isCloseable,level, localizationId, className) {...}

return Message(
  {
    level,
    key: className,
    className,
    isCloseable
  },
Depends on: 1540609
No longer depends on: 1540609
Assignee: nobody → ogasidlo
Status: NEW → ASSIGNED

Make the connection error + warning messages on the sidebar closeable

Priority: -- → P1
Whiteboard: [remote-debugging-reserve]
Pushed by ogasidlo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2d1f25ac62f
added closing button to error messages on sidebar r=daisuke,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-16) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.