Figure out what to do with test262 realm tests that pass with same-compartment realms
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
We are skipping a number of realm-related tests in jstests.list that now do the right thing with same-compartment realms (the default behavior in the shell), but still fail with --more-compartments (the old behavior).
It would be nice to figure out a way to run these tests. Maybe only skip them if --more-compartments is used?
Applies to at least the following:
skip script test262/built-ins/Function/internals/Call/class-ctor-realm.js
skip script test262/built-ins/Proxy/apply/arguments-realm.js
skip script test262/built-ins/Proxy/apply/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/construct/arguments-realm.js
skip script test262/built-ins/Proxy/construct/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/defineProperty/desc-realm.js
skip script test262/built-ins/Proxy/defineProperty/null-handler-realm.js
skip script test262/built-ins/Proxy/defineProperty/targetdesc-configurable-desc-not-configurable-realm.js
skip script test262/built-ins/Proxy/defineProperty/targetdesc-not-compatible-descriptor-not-configurable-target-realm.js
skip script test262/built-ins/Proxy/defineProperty/targetdesc-not-compatible-descriptor-realm.js
skip script test262/built-ins/Proxy/defineProperty/targetdesc-undefined-not-configurable-descriptor-realm.js
skip script test262/built-ins/Proxy/defineProperty/targetdesc-undefined-target-is-not-extensible-realm.js
skip script test262/built-ins/Proxy/defineProperty/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/deleteProperty/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/get/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/getOwnPropertyDescriptor/result-type-is-not-object-nor-undefined-realm.js
skip script test262/built-ins/Proxy/getOwnPropertyDescriptor/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/getPrototypeOf/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/has/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/isExtensible/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/ownKeys/return-not-list-object-throws-realm.js
skip script test262/built-ins/Proxy/ownKeys/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/preventExtensions/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/set/trap-is-not-callable-realm.js
skip script test262/built-ins/Proxy/setPrototypeOf/trap-is-not-callable-realm.js
skip script test262/built-ins/Array/length/define-own-prop-length-overflow-realm.js
skip script test262/built-ins/RegExp/prototype/multiline/cross-realm.js
skip script test262/built-ins/RegExp/prototype/global/cross-realm.js
skip script test262/built-ins/RegExp/prototype/sticky/cross-realm.js
skip script test262/built-ins/RegExp/prototype/ignoreCase/cross-realm.js
skip script test262/built-ins/RegExp/prototype/unicode/cross-realm.js
skip script test262/built-ins/RegExp/prototype/source/cross-realm.js
|
Assignee | |
Comment 1•5 years ago
|
||
Oh I see it's possible to use skip-if syntax in jstests.list. That might be an option.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jandem, could you have a look please?
For more information, please visit auto_nag documentation.
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/109f0deb14a4 Add an ignore-flag directive to jsreftest harness to allow running tests that pass without --more-compartments. r=jorendorff
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
Backed out for build bustages.
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=109f0deb14a403dd46a19c962e68ed66059e0b43&selectedJob=264701791
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=264701791&repo=autoland
Backout: https://hg.mozilla.org/integration/autoland/rev/80898589e1b159b81cba7a76d3ac23dce8bd5f1e
|
|
||
Updated•5 years ago
|
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f26741abcac Add an ignore-flag directive to jsreftest harness to allow running tests that pass without --more-compartments. r=jorendorff
|
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Description
•