1545079 - Create gtest for AudioCallbackDriver::Revive method

Status: RESOLVED FIXED

Description

[Alex Chronopoulos [:achronop]]

It requires to create a fake cubeb backend and plug it in AudioCallbackDriver. The benefit is that as soon as we have it in place we can use it to test more AudioCallbackDriver methods with gtests.

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The bot thinks this bug is a task, but please change it back in case of error.

Comment 2

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d717d01b6115b752fac21fb6bdda34c5df99a73

Comment 3

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce36268c8e05243b78fdb2dc300d2525ad03fc58

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545079 - Move MockCubeb on a seperate reusable header. r?padenot

Extract the existing MockCubeb logic from TestAudioDeviceEnumerator to a separate reusable header.

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545079 - Enhance MockCubeb class to simulate a cubeb stream. r?padenot

On MochCubeb add a fake audio thread and the corresponding methods for stream_{init,start,stop,destroy}.

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545079 - Execute revive logic in operation thread. r?padenot

IsStarted may not be updated at the time Revive() method is executed since the update of the flag happens on the async operation. This will be the case if Revive is executed right after Start. When that happens the revive method asserts that the stream is started.

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545079 - Create a gtest that exercises revive method of AudioCallbackDriver. r?padenot

Comment 8

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=256a09e77fd688d7fd074198fd0dc7183bf690b1

Comment 9

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac735dc609525d8d9adc4857f4b9e0fd96bff5b2

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21607f778c71
Move MockCubeb on a seperate reusable header. r=padenot
https://hg.mozilla.org/integration/autoland/rev/17935ce513d2
Enhance MockCubeb class to simulate a cubeb stream. r=padenot
https://hg.mozilla.org/integration/autoland/rev/70a4ba81a396
Execute revive logic in operation thread. r=padenot
https://hg.mozilla.org/integration/autoland/rev/7e8007308d0d
Create a gtest that exercises revive method of AudioCallbackDriver. r=padenot

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/21607f778c71
https://hg.mozilla.org/mozilla-central/rev/17935ce513d2
https://hg.mozilla.org/mozilla-central/rev/70a4ba81a396
https://hg.mozilla.org/mozilla-central/rev/7e8007308d0d