1545110 - Unexpected search shortcut in Topsites

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Nan Jiang [:nanj]]

A Google search shortcut was added to the Topsites while google was chosen as the default search engine. Per bug 1520853, AS should not create a search shortcut if it's set as the default search engine.

STR:

• Use a new profile in Nightly
• Perform a few searches in the address bar with the default search engine
• After a few newtab loads, a Google search will show up in the Topsites.

Expected:

AS won't create a Google search shortcut and add it to Topsites.

Comment 1

[Ed Lee :Mardak]

Bug 1520853 seems to be described and implemented relating to the default behavior for new profiles. I.e., don't create a google search shortcut for a new user on first run as the user can easily use google from the search box.

This bug would show up if google becomes a top site by the user frequently visiting google more than other sites, and it gets converted to a search shortcut. I'm not sure if this is a problem or not as the page is just trying to show the sites the user frequently visits.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ed Lee :Mardak from comment #1)

This bug would show up if google becomes a top site by the user frequently visiting google more than other sites, and it gets converted to a search shortcut. I'm not sure if this is a problem or not as the page is just trying to show the sites the user frequently visits.

I think the intention of this method was to filter out the current search engine from top sites: https://github.com/mozilla/activity-stream/blob/master/lib/TopSitesFeed.jsm#L129-L147

But I think it's getting short circuited in that second if statement?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

So I guess the bug to look at would be bug Bug 1479478.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)

But I think it's getting short circuited in that second if statement?

Hmm, or maybe that's just working as designed? I'm not sure :)

Comment 5

[Ed Lee :Mardak]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #2)

But I think it's getting short circuited in that second if statement?

Oh.. right. I guess it was implemented this way to allow google to appear as a default search shortcut, but now that we don't... I guess that whole if block can be removed? ??

Comment 6

[Nan Jiang [:nanj]]

Mike, what's your take on this? Is it expected?

Comment 7

[Mike Connor [:mconnor]]

Google should not show up organically. That's the point of the filter (otherwise it'll quickly become a top site because of bug 1461844).

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4983

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/mozilla/activity-stream/commit/99078fa4d9961d22004710360ebb5278ac796ddc

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/690025a0dcd5

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190509033505) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "Google" search shortcut is no longer added to "Top Sites".