1545168 - Picture-in-Picture context menu should be disabled for broken videos

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Visit the test case linked to this bug (URL field)
2. Right click on the video

ER:

The Picture-in-Picture context menu item should be disabled.

AR:

The Picture-in-Picture context menu item is enabled. Attempting to enter Picture-in-Picture doesn't result in anything occurring.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1545168 - Picture-in-Picture context menu item should be disabled on broken videos. r?jaws

For videos that break after alreading being in Picture-in-Picture, we keep the toggle enabled so
that the user can exit Picture-in-Picture.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a37009048470
Picture-in-Picture context menu item should be disabled on broken videos. r=jaws

Comment 3

[Raul Gurzau (:RaulG)]

Backed out 4 changesets (bug 1527925, bug 1545168, bug 1539567) for failing at /actions/test_media.html on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8515e58392b724460b731fe12881de75a2397c0a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=241082928&revision=f5273f8e51966ff5d45588bfcd1826a5642ba8b4

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241082928&repo=autoland&lineNumber=1347

Log snippet:

01:50:44 INFO - Invoke the 'invoke an action press at index undefined on ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]' test { scenario #0: expected 'name changed' event; }
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | No actions on the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | Wrong action name of the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - Buffered messages finished
01:50:44 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/actions/test_media.html | Test timed out.
01:50:44 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
01:50:44 INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:22
01:50:44 INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - TestRunner.runTests/<@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:381:20
01:50:44 INFO - promise callbackTestRunner.runTests@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:368:50
01:50:44 INFO - RunSet.runtests@chrome://mochikit/content/tests/SimpleTest/setup.js:201:14
01:50:44 INFO - RunSet.runall@chrome://mochikit/content/tests/SimpleTest/setup.js:180:12
01:50:44 INFO - hookupTests@chrome://mochikit/content/tests/SimpleTest/setup.js:273:12
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - hookup@chrome://mochikit/content/tests/SimpleTest/setup.js:253:5
01:50:44 INFO - linkAndHookup@chrome://mochikit/content/harness.xul:45:3
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - getTestList@chrome://mochikit/content/chrome-harness.js:251:3
01:50:44 INFO - loadTests@chrome://mochikit/content/harness.xul:24:3

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84110efda716
Picture-in-Picture context menu item should be disabled on broken videos. r=jaws

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/84110efda716

Comment 6

[Itiel]

I see no test case in this bug, so I've tried to reproduce this on attachment 8821802 [details].
I'm on latest Nightly now, and the toggle still appears on attachment 8821802 [details] (and, when clicked on, a nameless Nightly button appears in the taskbar, but no PIP flyout is shown). See attached.

Mike, is this expected after the fix here? See attached.

Comment 7

[Itiel]

Attachment: Screenshot

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Bah, so it looks like I forgot about the toggle and just fixed the context menu bit. :/

I'll file a new bug. Thanks for the heads up!

Comment 9

[Cristian Craciun]

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.