1545178 - [android x86-64] dom/ipc/tests/test_force_oop_iframe.html | application crashed [@ mozilla::dom::TabParent::RemoveWindowListeners()]

Status: RESOLVED INCOMPLETE

(Core :: DOM: Content Processes, defect, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

This is an error in M[tier-2](2) on Android 7.0 x86-64 opt which seems to have gone perma-orange with my stack landing on autoland: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=running%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cmochitests%2Ctest-android-em-7.0-x86_64%2Fopt-mochitest-e10s-2%2Cm(2)&selectedJob=240970026&revision=3592e8434aa07e699e29a1abcb96c72d5f9eb9f0

This appears to be caused by the Document associated with the frameloader of a tab being gone during shutdown, despite the corresponding content process and its nsFrameLoaders not being dead yet.

The crashing line appears to be: https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/dom/ipc/TabParent.cpp#358. It may be possible to fix by also null-checking OwnerDoc() in that if statement.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1545178 - Check that OwnerDoc is non-null within RemoveWindowListeners,

This line appears to be perma-failing right now in Android 7.0 x86-64 opt : M[tier-2](2). This seems to be being caused by the PContent's
channel being closed during shutdown also causing TabParents to be shut
down too late, after the document which they're embedded in has started
dying(?)

This patch just does the "obvious" thing of adding a null check (due to
it looking like a null dereference).

Comment 2

[Intermittent Failures Robot]

49 failures in 543 pushes (0.09 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 49

Platform breakdown:

• android-em-7-0-x86_64: 49

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545178&startday=2019-04-17&endday=2019-04-17&tree=all

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24545a98e9e1
Check that OwnerDoc is non-null within RemoveWindowListeners, r=qdot

Comment 4

[Intermittent Failures Robot]

88 failures in 502 pushes (0.175 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• try: 2
• autoland: 73
• mozilla-inbound: 10
• mozilla-central: 3

Platform breakdown:

• android-em-7-0-x86_64: 88

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545178&startday=2019-04-18&endday=2019-04-18&tree=all

Comment 5

[Cosmin Sabou [:CosminS]]

Nika, this still happens also after your latest push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cmochitests%2Ctest-android-em-7.0-x86_64%2Fopt-mochitest-e10s-2%2Cm%282%29&fromchange=24545a98e9e1a15b075bb27944a33353f385278a&tochange=24d0d307385d2cf5ce66854e40b92d7b15dc8428&selectedJob=241298035

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/24545a98e9e1

Comment 7

[Cosmin Sabou [:CosminS]]

This not yet fixed, see #c5.

Comment 8

[Intermittent Failures Robot]

110 failures in 354 pushes (0.311 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 97
• mozilla-inbound: 7
• mozilla-central: 4
• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 110

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545178&startday=2019-04-19&endday=2019-04-19&tree=all

Comment 9

[Intermittent Failures Robot]

26 failures in 151 pushes (0.172 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 13
• mozilla-inbound: 8
• mozilla-central: 3
• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 26

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545178&startday=2019-04-20&endday=2019-04-20&tree=all

Comment 10

[Razvan Maries]

Attachment: Bug 1545178 - Disabled test_force_oop_iframe.html on Android opt

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2049f9466646
Disabled test_force_oop_iframe.html on Android opt r=jmaher

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2049f9466646

Comment 13

[Intermittent Failures Robot]

341 failures in 2673 pushes (0.128 failures/push) were associated with this bug in the last 7 days.

This is the #4 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 285
• mozilla-central: 16
• mozilla-inbound: 32
• try: 8

Platform breakdown:

• android-em-7-0-x86_64: 341

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545178&startday=2019-04-15&endday=2019-04-21&tree=all

Comment 14

[Nika Layzell [:nika] (ni? for response)]

We are not currently planning on working with oop iframes on android immediately, and this particular form of oop iframes will not be present in that situation. It's probably OK that this test is disabled for now, though perhaps we will need to come back to it in the future.

Comment 15

[Chris Peterson [:cpeterson]]

Android Fission is post-MVP.

Comment 16

[Chris Peterson [:cpeterson]]

Resolving as incomplete because the test_force_oop_iframe.html test was removed in bug 1562029.