Closed Bug 1545226 Opened 6 months ago Closed 6 months ago

Some gtests in netwerk/test/gtest are not run on Android

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: gbrown, Assigned: kershaw)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Bug 1318091 started running gtest on our Android 7.0 test platform: gtest runs in the geckoview TestRunnerActivity, against an x86_64 build, running in an emulator running Android 7.0 on packet.net.

Many gtests run fine and pass consistently, but others did not and have been disabled.

netwerk/test/gtest tests disabled on Android can be found at:

https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/netwerk/test/gtest/moz.build#21

Priority: -- → P2
Whiteboard: [necko-triaged]

Kershaw, can you take a look?
MozURL you may ask Valentin.

Flags: needinfo?(kershaw)
Assignee: nobody → kershaw
Flags: needinfo?(kershaw)

TestMozURL failed because urltestdata.json is not existed [1].
It looks like it's a problem about gtest harness on Android. Other gtests that need to load external files, for example [2], are also disabled.

:gbrown, do you know why we failed to load an external file on Android test platform?

[1] https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/netwerk/test/gtest/TestMozURL.cpp#332
[2] https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/dom/media/gtest/moz.build#58

Flags: needinfo?(gbrown)
Depends on: 1548555

Thanks :kershaw. I didn't know that gtests sometimes relied on external support files like this. I'll try to find a way to copy those files to the device.

Flags: needinfo?(gbrown)

With changes from bug 1548555, one of the gtests previously disabled on Android
can be re-enabled, but most of the tests in netwerk/test/gtest are still problematic
(some won't build for me).

Keywords: leave-open

(In reply to Geoff Brown [:gbrown] from comment #4)

Created attachment 9062992 [details]
Bug 1545226 - Enable some android gtests in netwerk/test/gtest/parse-ftp; r=jmaher

With changes from bug 1548555, one of the gtests previously disabled on Android
can be re-enabled, but most of the tests in netwerk/test/gtest are still problematic
(some won't build for me).

I'll take a look at this. Thanks.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a580c406283
Enable some android gtests in netwerk/test/gtest/parse-ftp; r=jmaher

I think we can close this bug now, since all gtests in netwerk/test/gtest are enabled on Android.

Keywords: leave-open

That's great - thanks!

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.