1545256 - Permafailing create interactive task ac(create-inter) HTTPError: 400 Client Error: Bad Request for url: http://taskcluster/queue/v1/task/MsOmu2NoR427QR8759QNcg

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=241016540&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/f5FYTeIdT--7MvxzvlwHlw/runs/0/artifacts/public/logs/live_backing.log

*Example task details:* https://tools.taskcluster.net/groups/YgDcfh93SqWPwR-905WKWg/tasks/H18CvRe1StG7O60ulzodAQ/details

[task 2019-04-17T18:37:01.388Z] Creating task with taskId UIlEmMv-SiW8aAIKkKuquA for test-linux64/debug-marionette-e10s
[task 2019-04-17T18:37:01.671Z]
[task 2019-04-17T18:37:01.671Z] Schema Validation Failed!
[task 2019-04-17T18:37:01.671Z] Rejecting Schema: https://schemas.taskcluster.net/queue/v1/create-task-request.json#
[task 2019-04-17T18:37:01.671Z] Errors:
[task 2019-04-17T18:37:01.671Z] * data.dependencies should NOT have duplicate items (items ## 3 and 0 are identical)
[task 2019-04-17T18:37:01.671Z]
[task 2019-04-17T18:37:01.671Z] ---
[task 2019-04-17T18:37:01.671Z]
[task 2019-04-17T18:37:01.671Z] * method: createTask
[task 2019-04-17T18:37:01.671Z] * errorCode: InputValidationError
[task 2019-04-17T18:37:01.671Z] * statusCode: 400
[task 2019-04-17T18:37:01.671Z] * time: 2019-04-17T18:37:01.620Z
[task 2019-04-17T18:37:01.672Z] Traceback (most recent call last):
[task 2019-04-17T18:37:01.672Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 272, in action_callback
[task 2019-04-17T18:37:01.672Z] test=False)
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/registry.py", line 324, in trigger_action_callback
[task 2019-04-17T18:37:01.673Z] cb(Parameters(**parameters), graph_config, input, task_group_id, task_id)
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py", line 152, in create_interactive_action
[task 2019-04-17T18:37:01.673Z] parameters, modifier=edit)
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/util.py", line 166, in create_tasks
[task 2019-04-17T18:37:01.673Z] decision_task_id,
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 107, in create_tasks
[task 2019-04-17T18:37:01.673Z] f.result()
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/_base.py", line 398, in result
[task 2019-04-17T18:37:01.673Z] return self.__get_result()
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/third_party/python/futures/concurrent/futures/thread.py", line 55, in run
[task 2019-04-17T18:37:01.673Z] result = self.fn(*self.args, **self.kwargs)
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/create.py", line 133, in create_task
[task 2019-04-17T18:37:01.673Z] res.raise_for_status()
[task 2019-04-17T18:37:01.673Z] File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/models.py", line 840, in raise_for_status
[task 2019-04-17T18:37:01.673Z] raise HTTPError(http_error_msg, response=self)
[task 2019-04-17T18:37:01.673Z] HTTPError: 400 Client Error: Bad Request for url: http://taskcluster/queue/v1/task/UIlEmMv-SiW8aAIKkKuquA
[taskcluster 2019-04-17 18:37:02.302Z] === Task Finished ===
[taskcluster 2019-04-17 18:37:04.327Z] Unsuccessful task run with exit code: 1 completed in 17.518 seconds

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

That's not intermittent, it's a bug and probably deserves a backout.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, if it's an action task then it doesn't need a backout.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Maybe from bug 1541859?

Comment 4

[Aki Sasaki (not active)]

Ah, we should probably make that unique.

Comment 5

[Aki Sasaki (not active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04fa5334db60741af7b50ccad04f600ac476b53a shows my latest patch works.

• The create-interactive action doesn't specify decision_task_id in util.create_tasks. The child task has a taskGroupId that matches the action task's taskId. We don't want to modify the child task's dependencies in this case, because that results in duplicate dependencies.
• The add-task action specifies a decision_task_id of the hg-push decision taskId. The child task has a taskGroupId that matches the hg-push decision taskId. The child task also has the action task's taskId in its dependencies, which helps both identify the action that triggered it, and keeps it from running until the action task completes successfully.

Comment 6

[Aki Sasaki (not active)]

Attachment: Bug 1545256 - only append action TASK_ID to task deps if taskGroupId doesn't match r=dustin

We only want to append the action TASK_ID to the task dependencies when the taskGroupId doesn't match, otherwise we hit dup dependency errors.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e95b995fc086
only append action TASK_ID to task deps if taskGroupId doesn't match r=dustin

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e95b995fc086

Comment 10

[Intermittent Failures Robot]

5 failures in 2673 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 3
• mozilla-central: 2

Platform breakdown:

• gecko-decision: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1545256&startday=2019-04-15&endday=2019-04-21&tree=all