Closed Bug 1545296 Opened 1 year ago Closed 1 year ago

Clicking on the Picture-in-Picture toggle should not dispatch pointer / mouse events in content

Categories

(Toolkit :: Video/Audio Controls, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox68 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

(Depends on 1 open bug)

Details

Attachments

(5 files, 2 obsolete files)

Attached file Test case (obsolete) —

STR:

  1. Ensure that Picture-in-Picture is enabled (set media.videocontrols.picture-in-picture.video-toggle.enabled and media.videocontrols.picture-in-picture.enabled to true)

  2. Visit the testcase in this bug

  3. Hover the mouse over the video

  4. Click on the Picture-in-Picture toggle

ER:

The video should open in the Picture-in-Picture window

AR:

The video opens in the Picture-in-Picture window, but before doing so, shows some alerts from the content area in response to mousedown and mouseup events.

Attachment #9059116 - Attachment mime type: text/plain → text/html
Attachment #9059116 - Attachment is obsolete: true
Attached file Test case (obsolete) —
Attachment #9059117 - Attachment mime type: text/plain → text/html
Attachment #9059117 - Attachment is obsolete: true
Attachment #9060735 - Attachment mime type: text/plain → text/html
Summary: Clicking on the Picture-in-Picture toggle should not dispatch mousedown / mouseup / click events in content → Clicking on the Picture-in-Picture toggle should not dispatch pointer / mouse events in content
No longer blocks: 1545872

In this case, we want the Picture-in-Picture window to open, and we still want
to suppress all of the mouse button events from reaching content. We also want
to make sure that subsequent mouse button events all get sent down to content
normally.

Depends on D29680

Attachment #9062221 - Attachment description: Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?jaws → Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?JSON_Voorhees
Attachment #9062222 - Attachment description: Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?jaws → Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?JSON_voorhees
Attachment #9062223 - Attachment description: Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?jaws → Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?JSON_voorhees
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3cfd676266f
Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r=jaws
Attachment #9062221 - Attachment description: Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?JSON_Voorhees → Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?dthayer
Attachment #9062222 - Attachment description: Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?JSON_voorhees → Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?dthayer
Attachment #9062223 - Attachment description: Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?JSON_voorhees → Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?dthayer
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52b85c93b087
Add regression test for click event suppression for the Picture-in-Picture toggle. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/f779706e1c53
Factor out some helper functions for testing Picture-in-Picture toggles. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/550a15442d5b
Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r=dthayer

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.

Status: RESOLVED → VERIFIED
Depends on: 1576118
See Also: → 1612024
You need to log in before you can comment on or make changes to this bug.