1545296 - Clicking on the Picture-in-Picture toggle should not dispatch pointer / mouse events in content

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Test case

STR:

1. Ensure that Picture-in-Picture is enabled (set media.videocontrols.picture-in-picture.video-toggle.enabled and media.videocontrols.picture-in-picture.enabled to true)

2. Visit the testcase in this bug

3. Hover the mouse over the video

4. Click on the Picture-in-Picture toggle

ER:

The video should open in the Picture-in-Picture window

AR:

The video opens in the Picture-in-Picture window, but before doing so, shows some alerts from the content area in response to mousedown and mouseup events.

Comment 1

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Test case

Comment 2

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Test case

Comment 3

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1545296 - Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r?jaws

Comment 4

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?dthayer

Depends on D29422

Comment 5

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?dthayer

Depends on D29679

Comment 6

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?dthayer

In this case, we want the Picture-in-Picture window to open, and we still want
to suppress all of the mouse button events from reaching content. We also want
to make sure that subsequent mouse button events all get sent down to content
normally.

Depends on D29680

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3cfd676266f
Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r=jaws

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a3cfd676266f

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52b85c93b087
Add regression test for click event suppression for the Picture-in-Picture toggle. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/f779706e1c53
Factor out some helper functions for testing Picture-in-Picture toggles. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/550a15442d5b
Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r=dthayer

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/52b85c93b087
https://hg.mozilla.org/mozilla-central/rev/f779706e1c53
https://hg.mozilla.org/mozilla-central/rev/550a15442d5b

Comment 11

[Cristian Craciun]

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.