Clicking on the Picture-in-Picture toggle should not dispatch pointer / mouse events in content

RESOLVED FIXED in Firefox 68

Status

()

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect
Importance:
P1
normal
Status:
RESOLVED FIXED
Opened:
2 months ago
Updated:
Last month

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks 2 bugs)

Version:
unspecified
Target:
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(5 attachments, 2 obsolete attachments)

Test case
591 bytes, text/html
Details
Bug 1545296 - Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r?jaws
47 bytes, text/x-phabricator-request
Details | Review
Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?dthayer
47 bytes, text/x-phabricator-request
Details | Review
Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?dthayer
47 bytes, text/x-phabricator-request
Details | Review
Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?dthayer
47 bytes, text/x-phabricator-request
Details | Review
Assignee

Description

•
2 months ago
•
Edited
Posted file Test case (obsolete) —

STR:

  1. Ensure that Picture-in-Picture is enabled (set media.videocontrols.picture-in-picture.video-toggle.enabled and media.videocontrols.picture-in-picture.enabled to true)

  2. Visit the testcase in this bug

  3. Hover the mouse over the video

  4. Click on the Picture-in-Picture toggle

ER:

The video should open in the Picture-in-Picture window

AR:

The video opens in the Picture-in-Picture window, but before doing so, shows some alerts from the content area in response to mousedown and mouseup events.

 Assignee

Updated

•
2 months ago
Attachment #9059116 - Attachment mime type: text/plain → text/html
 Assignee

Updated

•
2 months ago
Attachment #9059116 - Attachment is obsolete: true
 Assignee

Comment 1

•
2 months ago
Posted file Test case (obsolete) —
Assignee

Updated

•
2 months ago
Attachment #9059117 - Attachment mime type: text/plain → text/html
 Assignee

Updated

•
2 months ago
Attachment #9059117 - Attachment is obsolete: true
 Assignee

Updated

•
2 months ago
Blocks: 1546634
 Assignee

Updated

•
2 months ago
Blocks: 1545750
 Assignee

Updated

•
2 months ago
Blocks: 1545771
 Assignee

Updated

•
2 months ago
Blocks: 1545872
 Assignee

Comment 2

•
2 months ago
Posted file Test case —
Assignee

Updated

•
2 months ago
Attachment #9060735 - Attachment mime type: text/plain → text/html
 Assignee

Updated

•
2 months ago
Summary: Clicking on the Picture-in-Picture toggle should not dispatch mousedown / mouseup / click events in content → Clicking on the Picture-in-Picture toggle should not dispatch pointer / mouse events in content
 Assignee

Updated

•
2 months ago
No longer blocks: 1545872
 Assignee

Comment 6

•
2 months ago

In this case, we want the Picture-in-Picture window to open, and we still want
to suppress all of the mouse button events from reaching content. We also want
to make sure that subsequent mouse button events all get sent down to content
normally.

Depends on D29680

 Assignee

Updated

•
2 months ago
See Also: → 1548616
Attachment #9062221 - Attachment description: Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?jaws → Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?JSON_Voorhees
Attachment #9062222 - Attachment description: Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?jaws → Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?JSON_voorhees
Attachment #9062223 - Attachment description: Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?jaws → Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?JSON_voorhees
 Assignee

Updated

•
2 months ago
Keywords: leave-open

Comment 7

•
2 months ago 
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3cfd676266f
Suppress mouse button events firing in content when clicking on the Picture-in-Picture toggle. r=jaws
Attachment #9062221 - Attachment description: Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?JSON_Voorhees → Bug 1545296 - Add regression test for click event suppression for the Picture-in-Picture toggle. r?dthayer
Attachment #9062222 - Attachment description: Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?JSON_voorhees → Bug 1545296 - Factor out some helper functions for testing Picture-in-Picture toggles. r?dthayer
Attachment #9062223 - Attachment description: Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?JSON_voorhees → Bug 1545296 - Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r?dthayer
Keywords: leave-open

Comment 9

•
Last month 
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52b85c93b087
Add regression test for click event suppression for the Picture-in-Picture toggle. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/f779706e1c53
Factor out some helper functions for testing Picture-in-Picture toggles. r=dthayer
https://hg.mozilla.org/integration/autoland/rev/550a15442d5b
Add a test for mousedown'ing on a Picture-in-Picture toggle, but mouseup'ing on something else. r=dthayer
You need to log in before you can comment on or make changes to this bug.