1545313 - browser.startup.blankWindow: Screen flashes when browser starts up (Direct3D 11/Win10+Win7)

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect, P2)

Description

[Alice0775 White]

Attachment: about:support

Screen flashes at browser startup. The screen goes black for a moment.
This is noticeable if browser is maximized.

Reproduced: always

Steps To Reproduce:

1. Maximized
2. Choose "Blank Page" for Homepage and new windows in option
3. Restart

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=be0d3112f763654b22e9d5d318b9c398297684b4&tochange=b3cffdee2f6caadc379280a90a8d85ca80870f3e

Regressed by:
b3cffdee2f6c Ryan Hunt — Bug 1544538 - Pref off advanced layers. r=jrmuizel

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window with forcibly set layers.mlgpu.enabled to false:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e21a2a57d05dfe3c5ff8ba71131127fa781ffdd0&tochange=f026ead5dbfce9d6530429ac568ecc5544cc9b3b

Regressed by:
f026ead5dbfc Florian Quèze — Bug 1447719 - Set browser.startup.blankWindow to true on Windows and Linux, r=mconley.

Comment 2

[Alice0775 White]

Screencast: https://youtu.be/r4VaQYkxc-M

Comment 3

[Alice0775 White]

please ignore comment#1

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

I was able to reproduce. Doesn't happen with Basic, WebRender or Advanced Layers.

Comment 5

[Darkspirit]

(Ryan Hunt [:rhunt] from bug 1547805 comment 5)

CompositorD3D11 is only on 2% of the users, so maybe that's why we haven't had it reported. I'd be curious if it was regressed by something in the meantime since we turned on AL.

This preexisting bug does not happen with browser.startup.blankWindow;false.
Mozregression (layers.mlgpu.enabled:false gfx.webrender.force-disabled:true) points to bug 1447719 comment 6.
comment 1 was correct.

Comment 6

[Alice0775 White]

The problem is now gone by b5867ca37387ceb32cb16f0c782b68a3c9519842 Ryan Hunt — Bug 1547805 - Pref advanced layers back on.

Comment 7

[Darkspirit]

Probably not gone for "2% of the users" and this still blocks switching advanced layers off again.

Comment 8

[Ryan Hunt [:rhunt] (on leave until early May)]

Yes, this bug is valid for the small amount of users who still get CompositorD3D11.

It's not a new regressions however, and because we turned advanced layers back on for most of the population the situation should be the same as previous releases. We should not track this for the firefox 68 release.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Dropping tracking per bug 1547805 and comment 8.

Comment 10

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1545313 - Don't force present if we haven't resized the swap chain yet. r?jrmuizel

This matches the behaviour of MLGDevice

Depends on D98036

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea7a5405334e
Don't force present if we haven't resized the swap chain yet. r=jrmuizel

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea7a5405334e

Comment 13

[Negritas Sergiu, Desktop QA]

Hello I have managed to reproduce the issue with the STR with Firefox 82.0a1 (2020-09-02).
I can confirm that the issue is fixed with Firefox Nightly 85.0a1(2020-12-13) 86.0a1 (2020-12-16). Updating the flags accordingly.