Closed Bug 1545351 Opened 2 years ago Closed 2 years ago

Some GeckoProfiler.h macros are missing namespace specifiers

Categories

(Core :: Gecko Profiler, defect, P3)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: gerald, Assigned: gerald)

Details

Attachments

(1 file)

Bug 1545351 - Add some missing namespaces in macros - r?mstange
47 bytes, text/x-phabricator-request
Details | Review

E.g., https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/tools/profiler/public/GeckoProfiler.h#760-764 :

#  define AUTO_PROFILER_TEXT_MARKER_CAUSE(markerName, text, categoryPair,     \
                                          cause)                              \
    AutoProfilerTextMarker PROFILER_RAII(                                     \
        markerName, text, JS::ProfilingCategoryPair::categoryPair, Nothing(), \
        Nothing(), cause)

If this macro was used outside of namespace mozilla or without an equivalent using-directive/declaration, it wouldn't find Nothing().

(Open question, while we're here: Should we specify absolute namespaces as well, e.g. ::mozilla::Nothing()?)

Some macros would not work if they were used in a context where namespace mozilla is not directly accessible. Fixed by added appropriate mozilla::
specifiers.

Assignee: nobody → gsquelart
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e75bfefbe442
Add some missing namespaces in macros - r=mstange

https://hg.mozilla.org/mozilla-central/rev/e75bfefbe442

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.