Closed Bug 1545362 Opened 1 year ago Closed 1 year ago

Remove HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8

Categories

(Thunderbird :: Installer, defect)

defect
Not set

Tracking

(thunderbird_esr6067+ fixed, thunderbird67 fixed, thunderbird68 fixed)

RESOLVED FIXED
Thunderbird 68.0
Tracking Status
thunderbird_esr60 67+ fixed
thunderbird67 --- fixed
thunderbird68 --- fixed

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

In bug 1521007 we added setting HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8 to 1. That was a mistake. Hence, in bug 1531724 we started setting it to 0. That still appears to cause issues, to it's best to remove the value altogether.

Removing HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8 will hopefully also remove HKLM\SOFTWARE\Wow6432Node\Clients\Mail\Mozilla Thunderbird - SupportUTF8

https://searchfox.org/comm-central/search?q=SupportUTF8&case=false&regexp=false&path=

Should be something like:

StrCpy $0 "Software\Clients\Mail\${ClientsRegName}"
DeleteRegValue HKLM $0 "SupportUTF8"

Richard, do you have time for this?

Something like this? I added it in the RemoveDeprecatedKeys macro as it seems to be run on every install/upgrade.

Assignee: nobody → richard.marti
Attachment #9059213 - Flags: review?(jorgk)

Thanks. Have you built an installer with mach package and used it to install and to check that the key is gone?

No, this creates only a zip file and I was never able to create a installer file. Could you start a try build?

Really? mach package for me builds an installer, I've used it many times. It ends up here:
C:\mozilla-source\comm-central\obj-x86_64-pc-mingw32\dist\install\sea\thunderbird-68.0a1.en-US.win64.installer.exe
18/04/2019 13:05 56,571,546 thunderbird-68.0a1.en-US.win64.installer.exe

I can try it locally if necessary.

Didn't knew that it's there. Checked on a Win7 VM, before the SupportUTF8 was in registry and after install no more. So it should work.

Thanks, I tried it myself locally. Same patch, tweaked comment.

Attachment #9059213 - Attachment is obsolete: true
Attachment #9059213 - Flags: review?(jorgk)
Attachment #9059251 - Flags: review+
Attachment #9059251 - Flags: approval-comm-esr60+
Attachment #9059251 - Flags: approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/899c32fe465c
Remove the SupportUTF8 registry value in HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird. r=jorgk

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Type: defect → task
Type: task → defect
Type: defect → task

(sorry for the oops)

Type: task → defect
You need to log in before you can comment on or make changes to this bug.