1545362 - Remove HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Jorg K (CEST = GMT+2)]

In bug 1521007 we added setting HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8 to 1. That was a mistake. Hence, in bug 1531724 we started setting it to 0. That still appears to cause issues, to it's best to remove the value altogether.

Removing HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird - SupportUTF8 will hopefully also remove HKLM\SOFTWARE\Wow6432Node\Clients\Mail\Mozilla Thunderbird - SupportUTF8

https://searchfox.org/comm-central/search?q=SupportUTF8&case=false&regexp=false&path=

Should be something like:

StrCpy $0 "Software\Clients\Mail\${ClientsRegName}"
DeleteRegValue HKLM $0 "SupportUTF8"

Richard, do you have time for this?

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1545362-remove-SupportUTF8-regKey.patch

Something like this? I added it in the RemoveDeprecatedKeys macro as it seems to be run on every install/upgrade.

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks. Have you built an installer with mach package and used it to install and to check that the key is gone?

Comment 3

[Richard Marti (:Paenglab)]

No, this creates only a zip file and I was never able to create a installer file. Could you start a try build?

Comment 4

[Jorg K (CEST = GMT+2)]

Really? mach package for me builds an installer, I've used it many times. It ends up here:
C:\mozilla-source\comm-central\obj-x86_64-pc-mingw32\dist\install\sea\thunderbird-68.0a1.en-US.win64.installer.exe
18/04/2019 13:05 56,571,546 thunderbird-68.0a1.en-US.win64.installer.exe

I can try it locally if necessary.

Comment 5

[Richard Marti (:Paenglab)]

Didn't knew that it's there. Checked on a Win7 VM, before the SupportUTF8 was in registry and after install no more. So it should work.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1545362-remove-SupportUTF8-regKey.patch

Thanks, I tried it myself locally. Same patch, tweaked comment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/899c32fe465c
Remove the SupportUTF8 registry value in HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird. r=jorgk

Comment 8

[Jorg K (CEST = GMT+2)]

TB 67 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/cc70860e0c101c319ad6908d2a0088993f7e6317

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60.7 ESR (or earlier, like TB 60.6.2):
https://hg.mozilla.org/releases/comm-esr60/rev/531b287058d3307aeb92a80051badbac99a50f63

Comment 10

[Wayne Mery (:wsmwk)]

(sorry for the oops)